Re: [PATCH] Tight check of pfn_valid on sparsemem - v4

Christoph Lameter
2010-07-28T15:14:59Z

On Wed, 28 Jul 2010, Minchan Kim wrote:

> static inline int memmap_valid(unsigned long pfn)
> {
> struct page *page = pfn_to_page(pfn);
> struct page *__pg = virt_to_page(page);

Does that work both for vmemmap and real mmapping?

> return page_private(__pg) == MAGIC_MEMMAP && PageReserved(__pg);
> }

Problem is that pages may be allocated for the mmap from a variety of
places. The pages in mmap_init_zone() and allocated during boot may have
PageReserved set whereas the page allocated via vmemmap_alloc_block() have
PageReserved cleared since they came from the page allocator.

You need to have consistent use of PageReserved in page structs for the
mmap in order to do this properly.

Simplest scheme would be to clear PageReserved() in all page struct
associated with valid pages and clear those for page structs that do not
refer to valid pages.

Then

mmap_valid = !PageReserved(xxx(pfn_to_page(pfn))