From: Waqar Hameed <waqar.hameed@axis.com>
To: <434779359@qq.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Linus Walleij" <linusw@kernel.org>,
"Bartosz Golaszewski" <brgl@kernel.org>,
liufulin <frank.liu@faiot.com>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH] tof: Add VL53L4CX TOF drivers
Date: Sun, 8 Feb 2026 18:00:11 +0100 [thread overview]
Message-ID: <pnda4xj1884.a.out@axis.com> (raw)
In-Reply-To: <tencent_326708D02875274DF25B10B91402B3828606@qq.com> (434779359@qq.com's message of "Sat, 7 Feb 2026 17:42:35 +0800")
On Sat, Feb 07, 2026 at 17:42 +0800 434779359@qq.com wrote:
> From: liufulin <frank.liu@faiot.com>
>
> This patch adds support for the vl53l4cx tof ic
> ICs used in Qualcomm reference designs
>
> Signed-off-by: liufulin <frank.liu@faiot.com>
[...]
Many of my initial comments have already been stated by Jonathan and
Andy. I still want to emphasize to run `scripts/checkpatch.pl` on your
patches (this one has 6761 errors and 11804 warnings...) before sending
them. (Shouldn't we have CI jobs for this?).
Some other general comments: please include a description of the device
and the chosen driver design. The linked datasheet doesn't explain all
the functionality used in this driver ([1] mentions some "host API"?).
Moreover, it seems like this driver is not originally written by you (by
looking at the copyright headers) and thus has some history that might
need some explanation?
[1] ch 3, p. 6, https://www.st.com/resource/en/datasheet/vl53l0x.pdf
prev parent reply other threads:[~2026-02-08 17:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-07 9:42 [PATCH] tof: Add VL53L4CX TOF drivers 434779359
2026-02-07 13:49 ` Jonathan Cameron
2026-02-07 21:41 ` Linus Walleij
2026-02-08 13:13 ` Andy Shevchenko
2026-02-14 16:25 ` Jonathan Cameron
2026-02-14 18:19 ` Andy Shevchenko
2026-02-07 17:13 ` kernel test robot
2026-02-08 2:19 ` kernel test robot
2026-02-08 17:00 ` Waqar Hameed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pnda4xj1884.a.out@axis.com \
--to=waqar.hameed@axis.com \
--cc=434779359@qq.com \
--cc=andy@kernel.org \
--cc=brgl@kernel.org \
--cc=broonie@kernel.org \
--cc=dlechner@baylibre.com \
--cc=frank.liu@faiot.com \
--cc=jic23@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox