From: Waqar Hameed <waqar.hameed@axis.com>
To: Linmao Li <lilinmao@kylinos.cn>
Cc: Sebastian Reichel <sre@kernel.org>, <linux-pm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] power: supply: bq25630: Scope battery information to bq25630_setup()
Date: Thu, 30 Jul 2026 21:22:36 +0200 [thread overview]
Message-ID: <pndbjbouvsz.a.out@axis.com> (raw)
In-Reply-To: <20260730011713.3332913-2-lilinmao@kylinos.cn> (Linmao Li's message of "Thu, 30 Jul 2026 09:17:12 +0800")
On Thu, Jul 30, 2026 at 09:17 +0800 Linmao Li <lilinmao@kylinos.cn> wrote:
> data->batinfo is only used by bq25630_setup() to program the initial
> charge limits, but power_supply_get_battery_info() allocates it on
> psy->dev, so it stays around for the lifetime of the device. Nothing
> else in the driver uses it.
>
> Get the battery information in bq25630_setup(), just before it is read,
> and release it on every path out of that function. The driver data no
> longer has to carry the pointer.
>
> Signed-off-by: Linmao Li <lilinmao@kylinos.cn>
Looks good, thanks!
Reviewed-by: Waqar Hameed <waqar.hameed@axis.com>
[...]
next prev parent reply other threads:[~2026-07-30 19:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 1:17 [PATCH v3 0/2] power: supply: bq25630: scope the battery information Linmao Li
2026-07-30 1:17 ` [PATCH v3 1/2] power: supply: bq25630: Scope battery information to bq25630_setup() Linmao Li
2026-07-30 19:22 ` Waqar Hameed [this message]
2026-07-30 1:17 ` [PATCH v3 2/2] power: supply: bq25630: Initialize hardware before exposing the power supply Linmao Li
2026-07-30 19:21 ` Waqar Hameed
2026-07-30 22:04 ` [PATCH v3 0/2] power: supply: bq25630: scope the battery information Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pndbjbouvsz.a.out@axis.com \
--to=waqar.hameed@axis.com \
--cc=lilinmao@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox