From: Waqar Hameed <waqar.hameed@axis.com>
To: Rajveer Chaudhari <rajveer.chaudhari.linux@gmail.com>
Cc: <jic23@kernel.org>, <dlechner@baylibre.com>, <nuno.sa@analog.com>,
<andy@kernel.org>, <linusw@kernel.org>,
<sakari.ailus@linux.intel.com>,
<harshit.m.mogalapalli@oracle.com>, <antoniu.miclaus@analog.com>,
<andrew.ijano@gmail.com>, <linux-iio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] iio: accel: bmc150: convert to guard(mutex)
Date: Mon, 9 Mar 2026 15:35:58 +0100 [thread overview]
Message-ID: <pndeclt5aup.a.out@axis.com> (raw)
In-Reply-To: <20260309142352.57407-2-rajveer.chaudhari.linux@gmail.com> (Rajveer Chaudhari's message of "Mon, 9 Mar 2026 19:53:49 +0530")
On Mon, Mar 09, 2026 at 19:53 +0530 Rajveer Chaudhari <rajveer.chaudhari.linux@gmail.com> wrote:
> Replace manual mutex_lock/mutex_unlock pair with guard(mutex) in
> bmc150_accel_buffer_predisable(). This ensures the mutex is
> released on all return paths and allows returning directly
> without a goto label.
>
> Aligned headers in alphabatical order.
Never mix unrelated changes. This should be separate patches. Why? Think
about traceability (bisect etc.).
This comment applies to all other patches in the series as well. I'll
just state it here and wait for V2 before taking a deeper look.
To be honest, I'm not even sure if sorting the headers is a "valid"
patch. It's just cosmetics (and there seems to be no such code style
guidelines)...
[...]
next prev parent reply other threads:[~2026-03-09 14:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 14:23 [PATCH 0/4] iio: accel: convert to guard(mutex) Rajveer Chaudhari
2026-03-09 14:23 ` [PATCH 1/4] iio: accel: bmc150: " Rajveer Chaudhari
2026-03-09 14:34 ` Rajveer Chaudhari
2026-03-09 14:35 ` Waqar Hameed [this message]
2026-03-09 16:26 ` Andy Shevchenko
2026-03-09 16:48 ` Waqar Hameed
2026-03-09 17:25 ` Rajveer Chaudhari
2026-03-09 14:23 ` [PATCH 2/4] iio: accel: mma8452: " Rajveer Chaudhari
2026-03-09 14:23 ` [PATCH 3/4] iio: accel: mma9551: " Rajveer Chaudhari
2026-03-09 14:23 ` [PATCH 4/4] iio: accel: sca3000: " Rajveer Chaudhari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pndeclt5aup.a.out@axis.com \
--to=waqar.hameed@axis.com \
--cc=andrew.ijano@gmail.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=jic23@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=rajveer.chaudhari.linux@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox