* [PATCH v2] i2c: mux-mule: Remove error print for devm_add_action_or_reset()
@ 2025-08-05 9:33 Waqar Hameed
0 siblings, 0 replies; only message in thread
From: Waqar Hameed @ 2025-08-05 9:33 UTC (permalink / raw)
To: Peter Rosin; +Cc: kernel, linux-i2c, linux-kernel
When `devm_add_action_or_reset()` fails, it is due to a failed memory
allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do
anything when error is `-ENOMEM`. Therefore, remove the useless call to
`dev_err_probe()` when `devm_add_action_or_reset()` fails, and just
return the value instead.
Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
Changes in v2:
* Split the patch to one seperate patch for each sub-system.
Link to v1: https://lore.kernel.org/all/pnd7c0s6ji2.fsf@axis.com/
drivers/i2c/muxes/i2c-mux-mule.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-mule.c b/drivers/i2c/muxes/i2c-mux-mule.c
index 284ff4afeeac..617ca058d2c9 100644
--- a/drivers/i2c/muxes/i2c-mux-mule.c
+++ b/drivers/i2c/muxes/i2c-mux-mule.c
@@ -91,8 +91,7 @@ static int mule_i2c_mux_probe(struct platform_device *pdev)
ret = devm_add_action_or_reset(mux_dev, mule_i2c_mux_remove, muxc);
if (ret)
- return dev_err_probe(mux_dev, ret,
- "Failed to register mux remove\n");
+ return ret;
/* Create device adapters */
for_each_child_of_node(mux_dev->of_node, dev) {
base-commit: 260f6f4fda93c8485c8037865c941b42b9cba5d2
--
2.39.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2025-08-05 9:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-05 9:33 [PATCH v2] i2c: mux-mule: Remove error print for devm_add_action_or_reset() Waqar Hameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).