From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9386A3806CD for ; Fri, 7 Aug 2026 03:31:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786073507; cv=none; b=Jd58jY6Y/qoRqtsF+OKDaFJHLUnqaJ6GP67XXe0M5Ro9jyzbBRhiZWYKlBcmzlfkov+XtwMYiNzHUV31L9uK4NfDU+jKOFrzvspf3L6BVc1fWZgH/QB5VzkZJBXGEv37BbZXp1nZ5BVBXw9D6jgDV5lRcRMD0ObXb66UBzV8KHE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786073507; c=relaxed/simple; bh=ZHMk6GGhLrW8MwM2HasObIG/LWJM80jkxom/AN/DLmA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GYWRjlr9k6QBjyCwpwWjsOLBSXJJCMIBRqilzVO6lRT8C1yt5OLjYX96muXqSPJbhHmNe9VpEDaTfqO8nRXMGPd8uE8Sj2DdN5lNbZ4vNMNg57hK7NS836o4KhdLq9A//ps/2CpvtkD06urJhgHMoYLdYPcTPVQrLr1Md0Cxczw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 7fe54e8e921011f1aa26b74ffac11d73-20260807 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:17bc8f88-179b-4294-825c-f8e819814ab2,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:e7bac3a,CLOUDID:931868f0700bd6dfc3791efc2f9cf001,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:81|82|102|865|898,TC:nil,Content:0|15|50 ,EDM:-3,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,O SA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 7fe54e8e921011f1aa26b74ffac11d73-20260807 X-User: liuxixin@kylinos.cn Received: from [127.0.1.1] [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1943659936; Fri, 07 Aug 2026 11:31:38 +0800 From: Xixin Liu To: linuxppc-dev@lists.ozlabs.org Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org, linux-kernel@vger.kernel.org, liuxixin@kylinos.cn Subject: [PATCH v1 4/4] powerpc/iommu: fix debugfs name buffer for 64-bit it_index Date: Fri, 07 Aug 2026 11:11:14 +0800 Message-ID: In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: patches/scripts/send-local.py iommu debugfs names sprintf() "%08lx" into char name[10]. The "8" in %08lx is a minimum width, so a 64-bit it_index can need up to 16 hex digits plus NUL. Size the buffer for an unsigned long and use snprintf. Signed-off-by: Xixin Liu --- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c index ee1b5cb557c9..e8f48aef7832 100644 --- a/arch/powerpc/kernel/iommu.c +++ b/arch/powerpc/kernel/iommu.c @@ -53,10 +53,11 @@ static void iommu_debugfs_add(struct iommu_table *tbl) { - char name[10]; + /* unsigned long hex + NUL; %08lx is a minimum width only */ + char name[2 * sizeof(unsigned long) + 1]; struct dentry *liobn_entry; - sprintf(name, "%08lx", tbl->it_index); + snprintf(name, sizeof(name), "%08lx", tbl->it_index); liobn_entry = debugfs_create_dir(name, iommu_debugfs_dir); debugfs_create_file_unsafe("weight", 0400, liobn_entry, tbl, &iommu_debugfs_fops_weight); @@ -70,9 +71,9 @@ static void iommu_debugfs_del(struct iommu_table *tbl) { - char name[10]; + char name[2 * sizeof(unsigned long) + 1]; - sprintf(name, "%08lx", tbl->it_index); + snprintf(name, sizeof(name), "%08lx", tbl->it_index); debugfs_lookup_and_remove(name, iommu_debugfs_dir); } #else -- 2.43.0