From: Christoph Rohland <cr@sap.com>
To: "Dunlap, Randy" <randy.dunlap@intel.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>, Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Patch] memparse should return long long
Date: 15 Jan 2001 18:25:06 +0100 [thread overview]
Message-ID: <qwwlmsciv7x.fsf@sap.com> (raw)
In-Reply-To: <D5E932F578EBD111AC3F00A0C96B1E6F07DBDF19@orsmsx31.jf.intel.com>
In-Reply-To: <D5E932F578EBD111AC3F00A0C96B1E6F07DBDF19@orsmsx31.jf.intel.com>
Hi Randy,
On Mon, 15 Jan 2001, Randy Dunlap wrote:
> Why not (?):
Because I did not need it (always used #G or #M) and did not know the
function. But it's apparently correct to use simple_strtoull.
>> diff -uNr 2.4.0-ac/lib/cmdline.c 2.4.0-ac-memparse/lib/cmdline.c
>> --- 2.4.0-ac/lib/cmdline.c Mon Aug 28 11:42:45 2000
>> +++ 2.4.0-ac-memparse/lib/cmdline.c Mon Jan 15 09:06:14 2001
>> @@ -93,9 +93,9 @@
>> * megabyte, or one gigabyte, respectively.
>> */
>>
>> -unsigned long memparse (char *ptr, char **retptr)
>> +unsigned long long memparse (char *ptr, char **retptr)
>> {
>> - unsigned long ret = simple_strtoul (ptr, retptr, 0);
>> + unsigned long long ret = simple_strtoul (ptr, retptr, 0);
> ! + unsigned long long ret = simple_strtoull (ptr, retptr, 0);
>
> ~Randy
Greetings
Christoph
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-01-15 17:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-15 16:50 [Patch] memparse should return long long Dunlap, Randy
2001-01-15 17:25 ` Christoph Rohland [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-01-15 8:22 Christoph Rohland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=qwwlmsciv7x.fsf@sap.com \
--to=cr@sap.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=randy.dunlap@intel.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox