From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8187736AB60 for ; Tue, 24 Feb 2026 09:26:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771925177; cv=none; b=CbQJPtAkvyLSTtL7+w3kELsBAQavWEZH/SJeIITd/JNdFKEmVZyjdIKwyrc5i+Ep3bGsoHBbWIe2QDpUWRvg7sxEipg/ispGfKPyB4SGfmSKFjwR1MBpGSrq291g8oxAdsMD39mA0J0oR7EQiAglUn/c1EUCMWjGFodZXYwc9Rg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771925177; c=relaxed/simple; bh=DeZh/d8iIUeK2m3V2aLrOBSeR795na8czkIeCGQ3A6I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FozMAQk/XWZd+sD0/GsEvWr55PxafORMcmPAM2ON3fAy+3KFO7VvK67owZkHe8BnyHQULfmnP9RZE2LugDnWEqzZNxD0zWioKfz7qKBPz3BOZeaGWAUumUtcYiW8WI4uGPAgaGGffWRSSgNq0n24K3UtG6z8EMpWE0AHKQ0Tmio= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YSXkWGSq; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YSXkWGSq" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-4376acce52eso3290654f8f.1 for ; Tue, 24 Feb 2026 01:26:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771925175; x=1772529975; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MhNrm0av+awaDMAZE+zf8q8wvC/W86Yd+ECEn3yTbic=; b=YSXkWGSqSEf5cWh8VBuSNGPvWERkj4gYMqc5G1YDk5HhUQk7rGyHgt+te0f0GC8c3m OVlxg1nyCAy2MJt5wDIfxKVVLzs/6ejc40GF99AbtkwptTDrHTbawqnxN/W75MQbXLME E1qww89GOAK/UG9EK5PKJcZdZz+UBIbJgt8FWmLdizp8rGFO6YHV/0vBmex9uTXWm7IL w5H7RVHE9KLYa2qxoRw1btv91kVKxUAUqsfWH/R69YrrUhyLZTVInDYqo6eOCBvb1dGz tiKEgM/BiEU8bqLWoOJLla1A59pjHgJDNq9okVtbHoAfOvZME+3h7RjSfx00JgW93Jla qCPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771925175; x=1772529975; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MhNrm0av+awaDMAZE+zf8q8wvC/W86Yd+ECEn3yTbic=; b=wgj+GD3ul4MYurC2ZwHypNIBEcVhReMR8tBEmzOTQ5QnzbDI2Khmoh26VYD2J5p1lQ wVFxkhxugAgJQxU70X9zSzkaEzHnxinoot2SIWiRqLxsbzaQ2X4DlxcH5wUMMwNQy8S9 mpDpjDxYdLv+r+YaIej3lHoXyVPfawmIHHUBmD3DbUcNllR93faTbZP6cFU8r+Ki3y2q 4T0d7Zm0gw81shSl9L07N7hJgmf0r65uwq9vFsaZkWbjbgm5Jrqs1/BZM8O0+XeXVWTf jf54KTw9jaDVFHbI622ggyIy+y9xJFaNGvG+itqeQ3YvxAAYuGjTnPDS6egTvLRSWe6W ZSQw== X-Forwarded-Encrypted: i=1; AJvYcCWRCSNZtW2M371E2iSiHc+yNzzRXM7Yj0LzV+n422+C7gmnFWWAOYRnowYuDYikxplOeHcEgR9s2p5JrNM=@vger.kernel.org X-Gm-Message-State: AOJu0YyFnEVnkNriZl+VrqX3kbjw/SZ1m9KmEd2nDDBBADKN9fR7uC7Z 7+qv642iKYVenlJLTLHREOZ33dpstr63gf7bG58TFH649ChnNO0p7DCJ X-Gm-Gg: AZuq6aKfc3GbeZcDX58coUHSkIEJ1pmyMBHQNz3NDlCFOyNLsiJ5GpUohgxjGtslRiS 8Q8Q0T9lGV7fHFijvGiAyjOqs5ux4S97uw+ZA9QUvKs5z0Blo06bIWVuOtnRdn3B+zqNEUqZfvH Jm3pGGCItIP7bKCDPoaeViJjk3zCCWr9oE5hjXRLCpdT3G5LTKSU88Hv9snbvNqHNJfYmyZXjzA uZ3G0vAVVXzF6qhHKIHcaWai+6L3cHmlF1Ce6pBVlZXsiZzwMgH/s0FATHgG3GJ3p9P/4+1OXpm +ciSwDoEtgQF9svnTIIVAc/7s+iq1eTG8b+Xgla4T4P19/gIoDkPb2mjTOvxC7nhRUR+vY9/CAX bi5V01yLYZlHtr/jWWt03WxUUnHIwsW+xJFbfLYlNoBBZ21gKtOFILumddBwV+d76EogJ1BewDK 4wWFQSWrKFA5kLKc2Q3ZM= X-Received: by 2002:a05:600c:3508:b0:46e:4e6d:79f4 with SMTP id 5b1f17b1804b1-483a95bf3d0mr215648355e9.15.1771925174582; Tue, 24 Feb 2026 01:26:14 -0800 (PST) Received: from luca-vm.lan ([154.61.61.58]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483b87db57fsm25049545e9.3.2026.02.24.01.26.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 01:26:14 -0800 (PST) From: Luca Leonardo Scorcia To: linux-mediatek@lists.infradead.org Cc: Krzysztof Kozlowski , Luca Leonardo Scorcia , Matthias Brugger , AngeloGioacchino Del Regno , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: Re: Re: [PATCH 1/2] dt-bindings: mfd: syscon: Add mt8516-syscfg Date: Tue, 24 Feb 2026 09:25:23 +0000 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: <296b000c-5970-4668-bd42-b99ca78d598f@collabora.com> References: <296b000c-5970-4668-bd42-b99ca78d598f@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi, I have successfully migrated the old driver to the pinctrl-paris platform. It turned out that 10005000 is the actual pinctrl register while 1000b000 is only used to configure eint. Once that was clear, adapting the driver was mostly a matter of being careful with offsets. Also there's a couple of obvious typos in the current maps that I fixed. Before I send in the patches I'd like a hint on how to package the changes as I hit a small issue. mt8167.dtsi includes mt8516.dtsi as they're very similar SoCs. They both currently define their pinctrl node like this: syscfg_pctl: syscfg-pctl@10005000 { compatible = "syscon"; reg = <0 0x10005000 0 0x1000>; }; pio: pinctrl@1000b000 { [...] reg = <0 0x1000b000 0 0x1000>; mediatek,pctl-regmap = <&syscfg_pctl>; [...] } With the paris-based driver, mt8167.dtsi changes as follows: pio: pinctrl@10005000 { [...] reg = <0 0x10005000 0 0x1000>, <0 0x1000b000 0 0x1000>; reg-names = "base", "eint"; [...] } After this change, the dtsi compiler rightly complains that the pio name is used for two different nodes. I am evaluating the following options: 1. I could edit the mt8516.dtsi to change its address in the name too and it _should_ still work, but I don't have a mt8516 board to actually test it. This however causes some dtbs warnings as the mediatek,pctl-regmap entry is not allowed by the paris driver. Cleaning the documentation would be tricky. 2. I could use /delete-node/ in mt8167 to remove the entry coming from mt8516. Ugly but does the job. 3. I could break the dependency of mt8167 from mt8516, this would mean duplicating some dts nodes but might be cleaner in the end. Still it's useful to know that those two SoC are mostly the same. 4. Lastly, I could migrate mt8516 to the paris driver too. With no board to test it and no datasheet however that's a bit risky. Do you have any suggestion or preference? Also, one last small question re: documentation. Would it be better to create a separate yaml file for this pinctrl or to add a compatible to one of the existing ones? I am looking at mt6795-pinctrl in particular. Thanks for your help!