public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@kernel.crashing.org>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, trini@kernel.crashing.org
Subject: [patch 15/15] Add hardware breakpoint support for i386
Date: Fri, 29 Jul 2005 14:21:46 -0700	[thread overview]
Message-ID: <resend.15.2972005.trini@kernel.crashing.org> (raw)
In-Reply-To: <resend.14.2972005.trini@kernel.crashing.org>



This adds hardware breakpoint support for i386.  This is not as well tested as
software breakpoints, but in some minimal testing appears to be functional.

---

 linux-2.6.13-rc3-trini/arch/i386/kernel/kgdb.c |   49 +++++++++++++++++++++++++
 1 files changed, 49 insertions(+)

diff -puN arch/i386/kernel/kgdb.c~i386 arch/i386/kernel/kgdb.c
--- linux-2.6.13-rc3/arch/i386/kernel/kgdb.c~i386	2005-07-29 12:02:15.000000000 -0700
+++ linux-2.6.13-rc3-trini/arch/i386/kernel/kgdb.c	2005-07-29 12:02:15.000000000 -0700
@@ -184,6 +184,54 @@ void kgdb_correct_hw_break(void)
 		asm volatile ("movl %0, %%db7\n"::"r" (dr7));
 }
 
+int kgdb_remove_hw_break(unsigned long addr)
+{
+	int i, idx = -1;
+	for (i = 0; i < 4; i++) {
+		if (breakinfo[i].addr == addr && breakinfo[i].enabled) {
+			idx = i;
+			break;
+		}
+	}
+	if (idx == -1)
+		return -1;
+
+	breakinfo[idx].enabled = 0;
+	return 0;
+}
+
+void kgdb_remove_all_hw_break(void)
+{
+	int i;
+
+	for (i = 0; i < 4; i++) {
+		if (breakinfo[i].enabled) {
+			/* Do what? */
+			;
+		}
+		memset(&breakinfo[i], 0, sizeof(struct hw_breakpoint));
+	}
+}
+
+int kgdb_set_hw_break(unsigned long addr)
+{
+	int i, idx = -1;
+	for (i = 0; i < 4; i++) {
+		if (!breakinfo[i].enabled) {
+			idx = i;
+			break;
+		}
+	}
+	if (idx == -1)
+		return -1;
+
+	breakinfo[idx].enabled = 1;
+	breakinfo[idx].type = 1;
+	breakinfo[idx].len = 1;
+	breakinfo[idx].addr = addr;
+	return 0;
+}
+
 void kgdb_disable_hw_debug(struct pt_regs *regs)
 {
 	/* Disable hardware debugging while we are in kgdb */
@@ -298,4 +346,5 @@ int kgdb_arch_init(void)
 
 struct kgdb_arch arch_kgdb_ops = {
 	.gdb_bpt_instr = {0xcc},
+	.flags = KGDB_HW_BREAKPOINT,
 };
_

  reply	other threads:[~2005-07-29 23:28 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1.2972005.trini@kernel.crashing.org>
2005-07-29 21:18 ` [patch 01/15] KGDB: Core files Tom Rini
2005-07-29 21:18   ` [patch 02/15] KGDB: i386 core functionality Tom Rini
2005-07-29 21:19     ` [patch 03/15] Basic PowerPC32 support Tom Rini
2005-07-29 21:19       ` [patch 04/15] I/O driver for 8250-compatible UARTs Tom Rini
2005-07-29 21:19         ` [patch 05/15] Basic MIPS support Tom Rini
2005-07-29 21:19           ` [patch 06/15] Basic IA64 support Tom Rini
2005-07-29 21:20             ` [patch 07/15] Basic x86_64 support Tom Rini
2005-07-29 21:20               ` [patch 08/15] Basic SuperH support Tom Rini
2005-07-29 21:20                 ` [patch 09/15] KGDB: Basic ARM support Tom Rini
2005-07-29 21:20                   ` [patch 10/15] Basic support for PowerPC64 Tom Rini
2005-07-29 21:20                     ` [patch 11/15] KGDB: KGDBoE I/O driver Tom Rini
2005-07-29 21:21                       ` [patch 12/15] KGDB: Add CFI DWARF2 annotation support Tom Rini
2005-07-29 21:21                         ` [patch 13/15] Minor SysRq keyboard bugfix for KGDB Tom Rini
2005-07-29 21:21                           ` [patch 14/15] Allow KGDB to work well with loaded modules Tom Rini
2005-07-29 21:21                             ` Tom Rini [this message]
2005-08-04  0:55                       ` [patch 11/15] KGDB: KGDBoE I/O driver Matt Mackall
2005-08-03 13:05               ` [patch 07/15] Basic x86_64 support Andi Kleen
2005-08-03 13:37                 ` Tom Rini
2005-08-04 12:39                   ` Andi Kleen
2005-08-04 14:04                     ` Tom Rini
2005-08-04 14:06                       ` Andi Kleen
2005-08-04 14:14                         ` Tom Rini
2005-08-04 14:28                           ` Andi Kleen
2005-08-04 15:06                             ` Tom Rini
2005-08-04 18:56                               ` Andi Kleen
2005-08-04 19:08                                 ` Tom Rini
2005-08-07  0:48                     ` Keith Owens
2005-08-08 17:56                       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=resend.15.2972005.trini@kernel.crashing.org \
    --to=trini@kernel.crashing.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox