* [PATCH] enable the gpu node
@ 2024-11-10 12:46 maud spierings via B4 Relay
2024-11-10 16:55 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: maud spierings via B4 Relay @ 2024-11-10 12:46 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, maud spierings
From: maud spierings <maud_spierings@hotmail.com>
enable the gpu node on the snapdragon powered asus vivobook s15
---
enables the gpu on the asus vivobook s15
Signed-off-by: maud spierings <maud_spierings@hotmail.com>
---
arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
index 8515c254e15868a5d7f378b0dc0bf8f339fc7b19..f25991b887de3fca0092c5f81c881c5d8bd71aac 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
@@ -328,6 +328,14 @@ vreg_l3j_0p8: ldo3 {
};
};
+&gpu {
+ status = "okay";
+
+ zap-shader {
+ firmware-name = "qcom/x1e80100/ASUSTeK/vivobook-s15/qcdxkmsuc8380.mbn";
+ };
+};
+
&i2c0 {
clock-frequency = <400000>;
status = "okay";
---
base-commit: 929beafbe7acce3267c06115e13e03ff6e50548a
change-id: 20241110-qcom-asus-gpu-870c7c22935c
Best regards,
--
maud spierings <maud_spierings@hotmail.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] enable the gpu node
2024-11-10 12:46 [PATCH] enable the gpu node maud spierings via B4 Relay
@ 2024-11-10 16:55 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2024-11-10 16:55 UTC (permalink / raw)
To: maud_spierings
Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-msm, devicetree, linux-kernel
On Sun, Nov 10, 2024 at 01:46:12PM +0100, maud spierings via B4 Relay wrote:
Please run
git log --oneline -- arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
and add a prefix to your subject line to make your change match others
to this file.
Please also drop "node", as it's the GPU you're actually enabling.
> From: maud spierings <maud_spierings@hotmail.com>
>
> enable the gpu node on the snapdragon powered asus vivobook s15
Looks good, please capitalize the 'e' at the beginning of your sentence.
>
> ---
Anything below the '---' line is omitted from the git history,
including your Signed-off-by. So move that above this line (and remove
the "enables..."-line below.
> enables the gpu on the asus vivobook s15
>
> Signed-off-by: maud spierings <maud_spierings@hotmail.com>
It would make me happy if you capitalized the 'm' and 's' in your
name...
Regards,
Bjorn
> ---
> arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
> index 8515c254e15868a5d7f378b0dc0bf8f339fc7b19..f25991b887de3fca0092c5f81c881c5d8bd71aac 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
> @@ -328,6 +328,14 @@ vreg_l3j_0p8: ldo3 {
> };
> };
>
> +&gpu {
> + status = "okay";
> +
> + zap-shader {
> + firmware-name = "qcom/x1e80100/ASUSTeK/vivobook-s15/qcdxkmsuc8380.mbn";
> + };
> +};
> +
> &i2c0 {
> clock-frequency = <400000>;
> status = "okay";
>
> ---
> base-commit: 929beafbe7acce3267c06115e13e03ff6e50548a
> change-id: 20241110-qcom-asus-gpu-870c7c22935c
>
> Best regards,
> --
> maud spierings <maud_spierings@hotmail.com>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-10 16:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-10 12:46 [PATCH] enable the gpu node maud spierings via B4 Relay
2024-11-10 16:55 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox