From: "Harald Küthe" <Harald.Kuethe@controlware.de>
To: <jolt@tuxbox.org>
Cc: <linuxppc-embedded@lists.linuxppc.org>, <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH][PPC32] 2.4.27: fixes for 8xx fec.c
Date: Tue, 10 Aug 2004 13:57:45 +0200 [thread overview]
Message-ID: <s118d477.053@post2.controlware.de> (raw)
Hi Florian
well you are right thank you.
Now the patch looks like:
diff -urN linux-2.4.27.orig/arch/ppc/8xx_io/fec.c linux-2.4.27/arch/ppc/8xx_io/fec.c
--- linux-2.4.27.orig/arch/ppc/8xx_io/fec.c 2003-11-28 19:26:18.000000000 +0100
+++ linux-2.4.27/arch/ppc/8xx_io/fec.c 2004-08-10 13:54:06.000000000 +0200
@@ -1466,6 +1466,8 @@
return -ENODEV; /* No PHY we understand */
#else
fep->link = 1;
+ /* after ifconfig down and up fec will not start -> restart it */
+ fec_restart (dev, 0);
netif_start_queue(dev);
return 0; /* Success */
#endif /* CONFIG_USE_MDIO */
@@ -2049,6 +2051,9 @@
fecp->fec_imask = ( FEC_ENET_TXF | FEC_ENET_TXB |
FEC_ENET_RXF | FEC_ENET_RXB | FEC_ENET_MII );
+ /* set old promiscuous/multicast settings which are lost above */
+ set_multicast_list(dev);
+
/* And last, enable the transmit and receive processing.
*/
fecp->fec_ecntrl = FEC_ECNTRL_PINMUX | FEC_ECNTRL_ETHER_EN;
Reagrds
Harald
>>> Florian Schirmer <jolt@tuxbox.org> 10.08.04 10:42:12 >>>
Hi,
>+
>+#ifndef CONFIG_USE_MDIO
>+ fec_restart (dev, 0);
>+#endif
>+
> netif_start_queue(dev);
> return 0; /* Success */
> #endif /* CONFIG_USE_MDIO */
>
>
Just a minor hint: you don't need the #ifndef CONFIG_USE_MDIO guard
since you're already in the non MDIO branch (see #endif comment).
Greetings,
Florian
reply other threads:[~2004-08-10 11:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s118d477.053@post2.controlware.de \
--to=harald.kuethe@controlware.de \
--cc=jolt@tuxbox.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-embedded@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox