From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03F14C433DB for ; Mon, 22 Mar 2021 11:27:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C56736191F for ; Mon, 22 Mar 2021 11:27:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229990AbhCVL07 (ORCPT ); Mon, 22 Mar 2021 07:26:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:37326 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230015AbhCVL0q (ORCPT ); Mon, 22 Mar 2021 07:26:46 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 20AF5ADD7; Mon, 22 Mar 2021 11:26:45 +0000 (UTC) Date: Mon, 22 Mar 2021 12:26:45 +0100 Message-ID: From: Takashi Iwai To: Arnd Bergmann Cc: Jaroslav Kysela , Takashi Iwai , Arnd Bergmann , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: core: avoid -Wempty-body warnings In-Reply-To: <20210322103128.547199-1-arnd@kernel.org> References: <20210322103128.547199-1-arnd@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Mar 2021 11:31:10 +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > Building with 'make W=1' shows some warnings about empty function-style > macros: > > sound/core/pcm_memory.c: In function 'preallocate_pages': > sound/core/pcm_memory.c:236:49: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] > 236 | preallocate_info_init(substream); > > sound/core/seq_device.c: In function 'snd_seq_device_dev_register': > sound/core/seq_device.c:163:41: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] > 163 | queue_autoload_drivers(); > > Change them to empty inline functions, which are more robust here. > > Signed-off-by: Arnd Bergmann Thanks, applied. Takashi