From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B76DECE564 for ; Tue, 18 Sep 2018 21:00:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BCE3C20C0E for ; Tue, 18 Sep 2018 21:00:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCE3C20C0E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730335AbeISCfS (ORCPT ); Tue, 18 Sep 2018 22:35:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:49912 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729859AbeISCfS (ORCPT ); Tue, 18 Sep 2018 22:35:18 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 789C3AF53; Tue, 18 Sep 2018 21:00:53 +0000 (UTC) Date: Tue, 18 Sep 2018 23:00:53 +0200 Message-ID: From: Takashi Iwai To: Paul Menzel Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: snd_hda_codec_hdmi: `hdaudio hdaudioC0D2: Unable to bind the codec` In-Reply-To: <533a0e85-0d03-740d-9f7e-8c29b5cca59f@molgen.mpg.de> References: <533a0e85-0d03-740d-9f7e-8c29b5cca59f@molgen.mpg.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 18 Sep 2018 17:55:15 +0200, Paul Menzel wrote: > > Dear Linux folks, > > > With drm-tip (v4.19-rc3-946-g09b295662edd) Linux prints > `snd_hda_codec_hdmi hdaudioC0D2: No i915 binding for Intel HDMI/DP codec` > to the log. > > ``` > […] > [ 12.481788] snd_hda_codec_realtek hdaudioC0D0: autoconfig for ALC671: line_outs=1 (0x21/0x0/0x0/0x0/0x0) type:line > [ 12.482536] snd_hda_codec_realtek hdaudioC0D0: speaker_outs=1 (0x17/0x0/0x0/0x0/0x0) > [ 12.483184] snd_hda_codec_realtek hdaudioC0D0: hp_outs=1 (0x14/0x0/0x0/0x0/0x0) > [ 12.483737] snd_hda_codec_realtek hdaudioC0D0: mono: mono_out=0x0 > [ 12.484198] snd_hda_codec_realtek hdaudioC0D0: inputs: > [ 12.484582] snd_hda_codec_realtek hdaudioC0D0: Front Mic=0x19 > [ 12.485100] snd_hda_codec_realtek hdaudioC0D0: Rear Mic=0x18 > [ 12.485519] snd_hda_codec_realtek hdaudioC0D0: Line=0x1a > [ 12.497685] snd_hda_codec_hdmi hdaudioC0D2: No i915 binding for Intel HDMI/DP codec > [ 12.498311] hdaudio hdaudioC0D2: Unable to bind the codec > [ 12.498789] input: HDA Intel PCH Front Mic as /devices/pci0000:00/0000:00:1f.3/sound/card0/input6 > [ 12.499567] input: HDA Intel PCH Rear Mic as /devices/pci0000:00/0000:00:1f.3/sound/card0/input7 > [ 12.500268] input: HDA Intel PCH Line as /devices/pci0000:00/0000:00:1f.3/sound/card0/input8 > [ 12.501039] input: HDA Intel PCH Line Out as /devices/pci0000:00/0000:00:1f.3/sound/card0/input9 > [ 12.501683] input: HDA Intel PCH Front Headphone as /devices/pci0000:00/0000:00:1f.3/sound/card0/input10 > [ 17.743338] [drm:intel_pch_type [i915]] Found SunrisePoint PCH > […] > ``` > > Is that an error or just a notice? This must be a side-effect of the recent change in i915 to be async probe. This made me checking the corresponding ALSA audio binding code change, and actually found a bug. Could you try the fix below? thanks, Takashi -- 8< -- From: Takashi Iwai Subject: [PATCH] ALSA: hda: Fix the audio-component completion timeout The timeout of audio component binding was incorrectly specified in msec, not in jiffies, which results in way too shorter timeout than expected. Along with fixing it, add the information print about the binding failure to show the unexpected situation more clearly. Fixes: a57942bfdd61 ("ALSA: hda: Make audio component support more generic") Signed-off-by: Takashi Iwai --- sound/hda/hdac_i915.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/hda/hdac_i915.c b/sound/hda/hdac_i915.c index b5282cbbe489..617ff1aa818f 100644 --- a/sound/hda/hdac_i915.c +++ b/sound/hda/hdac_i915.c @@ -145,9 +145,11 @@ int snd_hdac_i915_init(struct hdac_bus *bus) if (!acomp->ops) { request_module("i915"); /* 10s timeout */ - wait_for_completion_timeout(&bind_complete, 10 * 1000); + wait_for_completion_timeout(&bind_complete, + msecs_to_jiffies(10 * 1000)); } if (!acomp->ops) { + dev_info(bus->dev, "couldn't bind with audio component\n"); snd_hdac_acomp_exit(bus); return -ENODEV; } -- 2.18.0