From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tiwai@suse.de>
X-Google-Smtp-Source: AG47ELupFGKq4i7B7JzHoSe6rpOVaHYBwcmjFmMAn+LJYW4uunneauWa1rHdRdsrtFePJ562yxhz
ARC-Seal: i=1; a=rsa-sha256; t=1521476938; cv=none;
        d=google.com; s=arc-20160816;
        b=DxLlN6DawKQutK3269mVC3N2YyYkxiAp8iaXy5FbN7sBORaIvVYAICzo3qF+Evhq8T
         0NQ6Dkvdge0o2JX3xIMmonoVnWCoGxl9K+2fztMZuMl5khafuEFzZVl8DMSQih0R5kf0
         /6TfPCqjNx+/Y73nrrXyN9Y4u4TXeq309+J+oLzwnIoHfZi/9NhTzuZvPEUIi2iBSS9a
         1QNSHPancj5wv1hJP7+wvZOPLicskefy7ZmmbATeApfDPcQ0QX4XGTefqpuQH9nVz8Zv
         5KujtMe1fyN0HwE0RxQZ90VbxAhDNZNW1fVOJDNcHMVDnf65PrbRJlFAqYsg7N70r9m6
         mJ3Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from
         :message-id:date:arc-authentication-results;
        bh=grNLNVy21OfrgJreHIVymUzDqo3J0wEjlW+jbppxqdg=;
        b=w4ePcDf/QHYug/oeRCYOAvSfP6habRuU/FZzC9rK2eSr8ZGqRlRmEC8prBDPWi+Xxk
         LIHZVsQ18y/B36DvBBtmpd+h5FKnKElo9kx7O8iHjeVXvwKflw2OqWRfceaPcctVP/dH
         VFSd9SaNLOu78WTu4bjF/fLgG7wL6jfYSdRPj1vZNeaz5i7St2SjxJ9UlVu34+mmYYEw
         xoHABrdoXb3PchcAVVqtNc0bJwINekRGM2+lkkWnAi5sAlALjULB3hDeKuYTYpz6azuE
         MfJ6a6VTCYdFf5bfEJD/MKe1TEmqisrW9nkyc8IpWncpVKs7ENeAgd8XWIDw+s72TPbH
         nlgQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of tiwai@suse.de designates 195.135.220.15 as permitted sender) smtp.mailfrom=tiwai@suse.de
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of tiwai@suse.de designates 195.135.220.15 as permitted sender) smtp.mailfrom=tiwai@suse.de
Date: Mon, 19 Mar 2018 17:28:56 +0100
Message-ID: <s5h1sggvxkn.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Ruslan Bilovol" <ruslan.bilovol@gmail.com>
Cc: <alsa-devel@alsa-project.org>,
	"Jorge" <jorge.sanjuan@codethink.co.uk>,
	"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] ALSA: usb: initial USB Audio Device Class 3.0 support
In-Reply-To: <1521423963-24677-3-git-send-email-ruslan.bilovol@gmail.com>
References: <1521423963-24677-1-git-send-email-ruslan.bilovol@gmail.com>
	<1521423963-24677-3-git-send-email-ruslan.bilovol@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: =?utf-8?q?1595328661372171880?=
X-GMAIL-MSGID: =?utf-8?q?1595384202312657127?=
X-Mailing-List: linux-kernel@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>

On Mon, 19 Mar 2018 02:46:03 +0100,
Ruslan Bilovol wrote:
> 
> Recently released USB Audio Class 3.0 specification
> introduces many significant changes comparing to
> previous versions, like
>  - new Power Domains, support for LPM/L1
>  - new Cluster descriptor
>  - changed layout of all class-specific descriptors
>  - new High Capability descriptors
>  - New class-specific String descriptors
>  - new and removed units
>  - additional sources for interrupts
>  - removed Type II Audio Data Formats
>  - ... and many other things (check spec)
> 
> It also provides backward compatibility through
> multiple configurations, as well as requires
> mandatory support for BADD (Basic Audio Device
> Definition) on each ADC3.0 compliant device
> 
> This patch adds initial support of UAC3 specification
> that is enough for Generic I/O Profile (BAOF, BAIF)
> device support from BADD document.
> 
> Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>

Most code changes look fairly straightforward, and not breaking the
UAC1/UAC2 stuff.  So the stuff is good enough through a quick glance.

I suppose it's better to merge via sound git tree.
Greg, could you check include/linux/usb/* (and uapi) stuff and give an
ack if it's OK?

In anyway, I'll check the specs and compare with the definitions in
this patch.


And, just minor nitpicking regarding the code change: 

it's better to drop the parentheses in a line like below

> +		if ((protocol == UAC_VERSION_1) || (protocol == UAC_VERSION_2)) {

that is,
		if (protocol == UAC_VERSION_1 || protocol == UAC_VERSION_2) {

The indentation became so deep in some functions, and it's better to
refactor, but this can be done later once after all implementations
are finished.


thanks,

Takashi