* [PATCH] ALSA: 6fire: remove unused variable card
@ 2017-10-16 12:35 Colin King
2017-10-16 12:49 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-10-16 12:35 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Markus Elfring, Arvind Yadav,
alsa-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The pointer card is being assigned a value but it is never used.
Remove this redundant variable. Cleans up clang warning:
Value stored to 'card' is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/usb/6fire/chip.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/usb/6fire/chip.c b/sound/usb/6fire/chip.c
index c7641cb50616..17d5e3ee6d73 100644
--- a/sound/usb/6fire/chip.c
+++ b/sound/usb/6fire/chip.c
@@ -174,11 +174,9 @@ static int usb6fire_chip_probe(struct usb_interface *intf,
static void usb6fire_chip_disconnect(struct usb_interface *intf)
{
struct sfire_chip *chip;
- struct snd_card *card;
chip = usb_get_intfdata(intf);
if (chip) { /* if !chip, fw upload has been performed */
- card = chip->card;
chip->intf_count--;
if (!chip->intf_count) {
mutex_lock(®ister_mutex);
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ALSA: 6fire: remove unused variable card
2017-10-16 12:35 [PATCH] ALSA: 6fire: remove unused variable card Colin King
@ 2017-10-16 12:49 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2017-10-16 12:49 UTC (permalink / raw)
To: Colin King
Cc: alsa-devel, Arvind Yadav, Jaroslav Kysela, Markus Elfring,
kernel-janitors, linux-kernel
On Mon, 16 Oct 2017 14:35:58 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer card is being assigned a value but it is never used.
> Remove this redundant variable. Cleans up clang warning:
> Value stored to 'card' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-16 12:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-16 12:35 [PATCH] ALSA: 6fire: remove unused variable card Colin King
2017-10-16 12:49 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox