From: Takashi Iwai <tiwai@suse.de>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Matthew Ranostay <mranostay@embeddedalley.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sound: correct bracketing in spdif test
Date: Wed, 22 Oct 2008 08:02:09 +0200 [thread overview]
Message-ID: <s5h1vy9182m.wl%tiwai@suse.de> (raw)
In-Reply-To: <48FEA037.4050007@embeddedalley.com>
At Tue, 21 Oct 2008 23:38:31 -0400,
Matthew Ranostay wrote:
>
> Harvey Harrison wrote:
> > Noticed by sparse:
> > sound/pci/hda/patch_sigmatel.c:1285:43: warning: dubious: !x & y
> >
> > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> > ---
> > sound/pci/hda/patch_sigmatel.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> > index a2ac720..788fdc6 100644
> > --- a/sound/pci/hda/patch_sigmatel.c
> > +++ b/sound/pci/hda/patch_sigmatel.c
> > @@ -1282,7 +1282,7 @@ static int stac92xx_build_controls(struct hda_codec *codec)
> > return err;
> > spec->multiout.share_spdif = 1;
> > }
> > - if (spec->dig_in_nid && (!spec->gpio_dir & 0x01)) {
> > + if (spec->dig_in_nid && !(spec->gpio_dir & 0x01)) {
> > err = snd_hda_create_spdif_in_ctls(codec, spec->dig_in_nid);
> > if (err < 0)
> > return err;
>
> Thanks for finding this.
>
>
> Acked-by: Matthew Ranostay <mranostay@embeddedalley.com>
Applied now. Thanks!
Takashi
prev parent reply other threads:[~2008-10-22 6:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 3:28 [PATCH] sound: correct bracketing in spdif test Harvey Harrison
2008-10-22 3:38 ` Matthew Ranostay
2008-10-22 6:02 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h1vy9182m.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mranostay@embeddedalley.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox