From: Takashi Iwai <tiwai@suse.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: perex@suse.cz, Jason Gaston <jason.d.gaston@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.11.6 3/6] intel8x0: AC'97 audio patch for Intel ESB2
Date: Wed, 06 Apr 2005 18:00:20 +0200 [thread overview]
Message-ID: <s5h1x9nlwtn.wl@alsa2.suse.de> (raw)
In-Reply-To: <4252EE82.9000605@pobox.com>
At Tue, 05 Apr 2005 16:01:06 -0400,
Jeff Garzik wrote:
>
> Jason Gaston wrote:
> > Hello,
> >
> > This patch adds the Intel ESB2 DID's to the intel8x0.c file for AC'97 audio support. This patch was built against the 2.6.11.6 kernel.
> > If acceptable, please apply. Note: This patch depends on the previous 1/6 patch for pci_ids.h
> >
> > Thanks,
> >
> > Jason Gaston
> >
> > Signed-off-by: Jason Gaston <Jason.d.gaston@intel.com>
> >
> > --- linux-2.6.11.6/sound/pci/intel8x0.c.orig 2005-03-28 09:29:48.611042184 -0800
> > +++ linux-2.6.11.6/sound/pci/intel8x0.c 2005-03-28 09:32:49.771501608 -0800
> > @@ -124,6 +125,9 @@
> > #ifndef PCI_DEVICE_ID_INTEL_ICH7_20
> > #define PCI_DEVICE_ID_INTEL_ICH7_20 0x27de
> > #endif
> > +#ifndef PCI_DEVICE_ID_INTEL_ESB2_13
> > +#define PCI_DEVICE_ID_INTEL_ESB2_13 0x2698
> > +#endif
> > #ifndef PCI_DEVICE_ID_SI_7012
> > #define PCI_DEVICE_ID_SI_7012 0x7012
> > #endif
>
> (directed at the ALSA people, not Jason)
>
> These #ifdefs need to be removed from the mainline kernel sources.
Do you mean to remove all these PCI_DEVICE_ID_* definitions (#ifndef,
#define and #endif) from the driver part and put them in
include/linux/pci_ids.h if not exist?
Takashi
prev parent reply other threads:[~2005-04-06 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-05 15:10 [PATCH 2.6.11.6 3/6] intel8x0: AC'97 audio patch for Intel ESB2 Jason Gaston
2005-04-05 20:01 ` Jeff Garzik
2005-04-06 16:00 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h1x9nlwtn.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=jason.d.gaston@intel.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox