From: Takashi Iwai <tiwai@suse.de>
To: "Paweł Sikora" <pluto@pld-linux.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [oops] # rmmod snd_nm256
Date: Thu, 30 Dec 2004 17:12:24 +0100 [thread overview]
Message-ID: <s5h1xd7zrx3.wl@alsa2.suse.de> (raw)
In-Reply-To: <200412300059.42982.pluto@pld-linux.org>
At Thu, 30 Dec 2004 00:59:42 +0100,
Paweł Sikora wrote:
>
> # rmmod snd_nm256
> Oops: 0000 [#1]
Does the patch below fix the problem?
Takashi
--- linux/sound/pci/nm256/nm256.c 27 Dec 2004 13:32:57 -0000 1.61
+++ linux/sound/pci/nm256/nm256.c 30 Dec 2004 16:10:00 -0000
@@ -1486,12 +1486,6 @@
snd_nm256_init_chip(chip);
- if ((err = snd_nm256_pcm(chip, 0)) < 0)
- goto __error;
-
- if ((err = snd_nm256_mixer(chip)) < 0)
- goto __error;
-
// pci_set_master(pci); /* needed? */
snd_card_set_pm_callback(card, nm256_suspend, nm256_resume, chip);
@@ -1612,6 +1606,12 @@
chip->reset_workaround = 1;
}
+ if ((err = snd_nm256_pcm(chip, 0)) < 0 ||
+ (err = snd_nm256_mixer(chip)) < 0) {
+ snd_card_free(card);
+ return err;
+ }
+
sprintf(card->shortname, "NeoMagic %s", card->driver);
sprintf(card->longname, "%s at 0x%lx & 0x%lx, irq %d",
card->shortname,
next prev parent reply other threads:[~2004-12-30 16:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-29 23:59 [oops] # rmmod snd_nm256 Paweł Sikora
2004-12-30 16:12 ` Takashi Iwai [this message]
2005-01-08 0:42 ` Nicolas Michaux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h1xd7zrx3.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pluto@pld-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox