From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id F2736C433F5
	for <linux-kernel@archiver.kernel.org>; Fri, 22 Apr 2022 05:58:45 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233116AbiDVGBg (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Fri, 22 Apr 2022 02:01:36 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41840 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233058AbiDVGBb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 22 Apr 2022 02:01:31 -0400
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA4474F9DF
        for <linux-kernel@vger.kernel.org>; Thu, 21 Apr 2022 22:58:39 -0700 (PDT)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
        by smtp-out2.suse.de (Postfix) with ESMTP id 71CB31F745;
        Fri, 22 Apr 2022 05:58:38 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1650607118; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=mAdj96DBsr5nxeDeyqlp0nmr0SjkdrgI+4axBdvYC5w=;
        b=xASxMAIubK7nP6qIQlJ0If3b6gpOnAZiMAMO8pyQe92Iws8uuW7OeziZbbfIkOIKk6lhP6
        OKiXcJWeANEdpXRhmtMrCcV7XZaQryexNsX2kWNMy6Vq1K4kf7ZrYGMFBWBO6jmzW5sqbD
        NyHW8ylfkozghfoZiyYlC+dJdoJfweU=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1650607118;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=mAdj96DBsr5nxeDeyqlp0nmr0SjkdrgI+4axBdvYC5w=;
        b=+1FJLxcXtttys3GmCcGIqUu8myexJUnlFaOUFhgiEiUS3rRWhQouq/QfxQzFDjp9V4D1uZ
        +dUdggt9DoU6M1Bg==
Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42])
        by relay2.suse.de (Postfix) with ESMTP id 640EB2C14B;
        Fri, 22 Apr 2022 05:58:38 +0000 (UTC)
Date:   Fri, 22 Apr 2022 07:58:38 +0200
Message-ID: <s5h35i5veup.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Miles Chen <miles.chen@mediatek.com>
Cc:     <alsa-devel@alsa-project.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-mediatek@lists.infradead.org>, <matthias.bgg@gmail.com>,
        <perex@perex.cz>, <rdunlap@infradead.org>, <tiwai@suse.com>
Subject: Re: [PATCH -next V2] sound/oss/dmasound: fix 'dmasound_setup' defined but not used
In-Reply-To: <20220422025312.7718-1-miles.chen@mediatek.com>
References: <s5ha6cm4xy2.wl-tiwai@suse.de>
        <20220422025312.7718-1-miles.chen@mediatek.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 22 Apr 2022 04:53:12 +0200,
Miles Chen wrote:
> 
> Hi Taksshi,
> 
> >> We observed: 'dmasound_setup' defined but not used error with
> >> COMPILER=gcc ARCH=m68k DEFCONFIG=allmodconfig build.
> >> 
> >> Fix it by adding __maybe_unused to dmasound_setup.
> >> 
> >> Error(s):
> >> sound/oss/dmasound/dmasound_core.c:1431:12: error: 'dmasound_setup' defined but not used [-Werror=unused-function]
> >> 
> >> Fixes: 9dd7c46346ca ("sound/oss/dmasound: fix build when drivers are mixed =y/=m")
> >> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
> >> Cc: Takashi Iwai <tiwai@suse.com>
> >
> >Thanks, applied.
> 
> This patch is needed in 5.18-rc3 [1] too, should I submit another patch or
> you can pick it to the mainstream?

It's included in the branch for the next PR to 5.18.


thanks,

Takashi