From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EF4BC282DD for ; Thu, 9 Jan 2020 18:57:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 17733206ED for ; Thu, 9 Jan 2020 18:57:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730811AbgAIS5h (ORCPT ); Thu, 9 Jan 2020 13:57:37 -0500 Received: from mx2.suse.de ([195.135.220.15]:58202 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729054AbgAIS5h (ORCPT ); Thu, 9 Jan 2020 13:57:37 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 48396B1EC; Thu, 9 Jan 2020 18:57:35 +0000 (UTC) Date: Thu, 09 Jan 2020 19:57:34 +0100 Message-ID: From: Takashi Iwai To: Sriram Periyasamy Cc: Jeff Chang , lgirdwood@gmail.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.com, jeff_chang@richtek.com, broonie@kernel.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [alsa-devel] [PATCH v4] ASoC: Add MediaTek MT6660 Speaker Amp Driver In-Reply-To: <20200109171833.GA2709@sriram-VirtualBox> References: <1578366545-30251-1-git-send-email-richtek.jeff.chang@gmail.com> <20200109171833.GA2709@sriram-VirtualBox> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 09 Jan 2020 18:18:36 +0100, Sriram Periyasamy wrote: > > On Tue, Jan 07, 2020 at 11:09:05AM +0800, Jeff Chang wrote: > > From: Jeff Chang > > > > The MT6660 is a boosted BTL class-D amplifier with V/I sensing. > > A built-in DC-DC step-up converter is used to provide efficient > > power for class-D amplifier with multi-level class-G operation. > > The digital audio interface supports I2S, left-justified, > > right-justified, TDM and DSP A/B format for audio in with a data > > out used for chip information like voltage sense and current > > sense, which are able to be monitored via DATAO through proper > > > > diff --git a/sound/soc/codecs/mt6660.c b/sound/soc/codecs/mt6660.c > > new file mode 100644 > > index 0000000..b8fc53b > > --- /dev/null > > +++ b/sound/soc/codecs/mt6660.c > > @@ -0,0 +1,628 @@ > > > + > > +struct codec_reg_val { > > + u32 addr; > > + u32 mask; > > + u32 data; > > +}; > > packed structures could have been better. It depends. Packing may break alignment and the performance may suffer from it. So, in general, __packed is recommended when the size matters (e.g. lots of objects / arrays are created) or it's about ABI that needs the fixed consistent size. thanks, Takashi