From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033650AbdDTUYU (ORCPT ); Thu, 20 Apr 2017 16:24:20 -0400 Received: from mx2.suse.de ([195.135.220.15]:53697 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1033360AbdDTUYQ (ORCPT ); Thu, 20 Apr 2017 16:24:16 -0400 Date: Thu, 20 Apr 2017 22:24:14 +0200 Message-ID: From: Takashi Iwai To: Mark Brown Cc: Jose Abreu , Lubomir Rintel , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Arnd Bergmann Subject: Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm as a module In-Reply-To: <20170420194646.qcpu7w3acjyfmeu5@sirena.org.uk> References: <20170418105954.23368-1-lkundrak@v3.sk> <20170418151834.c7e5fivmgn73sbwd@sirena.org.uk> <1492532010.28092.12.camel@v3.sk> <20170418171519.csiftftd434psyn5@sirena.org.uk> <2e39b000-bf25-6447-b53b-047401041f4e@synopsys.com> <1492618461.28092.18.camel@v3.sk> <03a3fbbb-7221-f4ee-5b1b-8fff518ea82c@synopsys.com> <20170420194646.qcpu7w3acjyfmeu5@sirena.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Apr 2017 21:46:46 +0200, Mark Brown wrote: > > On Wed, Apr 19, 2017 at 05:48:15PM +0100, Jose Abreu wrote: > > > What do you think Mark? If you want to keep the PCM as a module > > then we will need to abstract this more, by reducing the > > dependencies. > > I think forcing this to be built in to the kernel (which is what the > commit message says the change is going to do) is an obviously bad > idea. Anything we add to the base kernel image needs to have a good > reason to be there and it is hard to think what that reason might be for > any audio driver, we need to be able to put this code into a module. Well, I guess the original patch description caused a big confusion. As far as I see, the intention of the patch is not about the module or built-in kernel. Instead it's rather to fold designware_pcm stuff into the single designware_i2s driver. The former is merely an extension of the latter driver, and the latter invokes the former directly. Thus there is little merit to keep them separate. I think the current code is even buggy, which allows to leave CONFIG_SND_DESIGNWARE_I2S=y and CONFIG_SND_DESIGNWARE_PCM=m. So, I think Lubomir's change is right. But the patch subject and description should be rephrased. One thing I don't like is the rename of the file. But in this particular case, it's unavoidable unless we rename the module name. BTW, we should drop the superfluous EXPORT_SYMBOL*(), too. thanks, Takashi