From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759132AbcALFmp (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 Jan 2016 00:42:45 -0500
Received: from mx2.suse.de ([195.135.220.15]:54471 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750761AbcALFmn (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 Jan 2016 00:42:43 -0500
Date: Tue, 12 Jan 2016 06:42:42 +0100
Message-ID: <s5h37u3pd4d.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: PC Liao <pc.liao@mediatek.com>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
        srv_heupstream <srv_heupstream@mediatek.com>,
        "linux-mediatek@lists.infradead.org" 
	<linux-mediatek@lists.infradead.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        =?UTF-8?B?Iktvcm8gQ2hlbiAo6Zmz5oCd57+wKSI=?= 
	<koro.chen@mediatek.com>,
        =?UTF-8?B?IkhpZGFsZ28gSHVhbmcgKOm7g+ato+WSjCki?= 
	<Hidalgo.Huang@mediatek.com>
Subject: Re: [PATCH] ASoC: mediatek: Enable 33bit memory address to support 4GB DRAM
In-Reply-To: <1452567284.8331.12.camel@mtksdaap41>
References: <1452499250-5202-1-git-send-email-pc.liao@mediatek.com>
	<s5hwprgcwv6.wl-tiwai@suse.de>
	<1452567284.8331.12.camel@mtksdaap41>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 12 Jan 2016 03:54:44 +0100,
PC Liao wrote:
> 
> On Mon, 2016-01-11 at 17:02 +0800, Takashi Iwai wrote:
> > On Mon, 11 Jan 2016 09:00:50 +0100,
> > PC Liao wrote:
> > > 
> > > @@ -603,7 +606,10 @@ static int mtk_afe_dais_hw_params(struct snd_pcm_substream *substream,
> > >  	if (ret < 0)
> > >  		return ret;
> > >  
> > > -	memif->phys_buf_addr = substream->runtime->dma_addr;
> > > +	if (sizeof(dma_addr_t) > 4)
> > > +		msb_at_bit33 = (substream->runtime->dma_addr & 0x100000000) ? 1 : 0;
> > 
> > Better to put a proper suffix for the constant over 32bit.
> > 
> > Or use upper_32_bits().  Then sizeof() check can be omitted, as the
> > compiler should be smart enough to know it beforehand.
> > 
> > 
> > Takashi
> 
> 
> Hi Takashi,
> 
> Thanks for your comment.
> I change as below:
> @@ -606,10 +606,8 @@ static int mtk_afe_dais_hw_params(struct
> snd_pcm_substream
>         if (ret < 0)
>                 return ret;
> 
> -       if (sizeof(dma_addr_t) > 4)
> -               msb_at_bit33 = (substream->runtime->dma_addr &
> 0x100000000) ? 1
> -
> -       memif->phys_buf_addr = substream->runtime->dma_addr &
> 0xffffffff;
> +       msb_at_bit33 = upper_32_bits(substream->runtime->dma_addr) ? 1 :
> 0;
> +       memif->phys_buf_addr =
> lower_32_bits(substream->runtime->dma_addr);
> 
> 
> Dose this change follow your idea?

Yes.


Takashi