From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751546Ab1AVQY4 (ORCPT ); Sat, 22 Jan 2011 11:24:56 -0500 Received: from cantor.suse.de ([195.135.220.2]:57011 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750817Ab1AVQY4 (ORCPT ); Sat, 22 Jan 2011 11:24:56 -0500 Date: Sat, 22 Jan 2011 17:24:52 +0100 Message-ID: From: Takashi Iwai To: Jesper Juhl Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Jaroslav Kysela , Clemens Ladisch Subject: Re: [PATCH][RFC] Sound, Xonar, CS43xx: Don't overrun static array In-Reply-To: References: User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 20 Jan 2011 22:37:43 +0100 (CET), Jesper Juhl wrote: > > > 'cs4398_regs' in 'struct xonar_cs43xx' is an array of 'u8' with a size of > 8. So, this code in sound/pci/oxygen/xonar_cs43xx.c::dump_d1_registers() > > for (i = 2; i <= 8; ++i) > snd_iprintf(buffer, " %02x", data->cs4398_regs[i]); > > will overrun the array when 'i == 8'. > > I guess that what's needed to fix it is the trivial patch below, but I > must admit that I have no idea about this code, so I may very well be > wrong. Additionally, I have no way to actually test this, so all I know is > that the below compiles. Someone who actually knows this code should take > a look before anything is comitted - consider the below (not much more > than) a bug report. > > Signed-off-by: Jesper Juhl Applied now. Thanks. Takashi > --- > xonar_cs43xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/oxygen/xonar_cs43xx.c b/sound/pci/oxygen/xonar_cs43xx.c > index 9f72d42..2527191 100644 > --- a/sound/pci/oxygen/xonar_cs43xx.c > +++ b/sound/pci/oxygen/xonar_cs43xx.c > @@ -392,7 +392,7 @@ static void dump_d1_registers(struct oxygen *chip, > unsigned int i; > > snd_iprintf(buffer, "\nCS4398: 7?"); > - for (i = 2; i <= 8; ++i) > + for (i = 2; i < 8; ++i) > snd_iprintf(buffer, " %02x", data->cs4398_regs[i]); > snd_iprintf(buffer, "\n"); > dump_cs4362a_registers(data, buffer); > > -- > Jesper Juhl http://www.chaosbits.net/ > Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html > Plain text mails only, please. >