From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755929AbXF0KCn (ORCPT ); Wed, 27 Jun 2007 06:02:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752722AbXF0KCf (ORCPT ); Wed, 27 Jun 2007 06:02:35 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56219 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752170AbXF0KCe (ORCPT ); Wed, 27 Jun 2007 06:02:34 -0400 Date: Wed, 27 Jun 2007 12:02:32 +0200 Message-ID: From: Takashi Iwai To: Randy Dunlap Cc: lkml , akpm , perex@suse.cz Subject: Re: [PATCH -mm] ALSA portman2x4 section mismatch In-Reply-To: <20070626153013.264f5a92.randy.dunlap@oracle.com> References: <20070626153013.264f5a92.randy.dunlap@oracle.com> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta27) (fiddleheads) (+CVS-20060704) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 26 Jun 2007 15:30:13 -0700, Randy Dunlap wrote: > > From: Randy Dunlap > > FIx section mismatch when CONFIG_HOTPLUG=n: > > WARNING: sound/built-in.o(.exit.text+0x271): Section mismatch: reference to .init.text:snd_p > ortman_unregister_all (between 'snd_portman_module_exit' and 'alsa_mpu401_uart_exit') > > Signed-off-by: Randy Dunlap I applied it to ALSA tree now because it's the simplest way to fix this warning. But, I'm still wondering whether it was really wrong. The function snd_portmap_unregister_all() is called both from the module init and exit functions. Would the module_exit function be called even CONFIG_MODULE=n ? If not, __init_or_module should be correct since the function is called only from module_init. thanks, Takashi > --- > sound/drivers/portman2x4.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-2.6.22-rc4-mm2.orig/sound/drivers/portman2x4.c > +++ linux-2.6.22-rc4-mm2/sound/drivers/portman2x4.c > @@ -833,7 +833,7 @@ static struct platform_driver snd_portma > /********************************************************************* > * module init stuff > *********************************************************************/ > -static void __init_or_module snd_portman_unregister_all(void) > +static void snd_portman_unregister_all(void) > { > int i; > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >