Re: [Alsa-devel] [2.6 patch] sound/core/: possible cleanups

[Takashi Iwai <tiwai@suse.de>]

At Wed, 18 May 2005 10:58:00 +0200,
Adrian Bunk wrote:
> 
> This patch contains the following possible cleanups:
> - make needlessly global code static
> - #if 0 the following unused global functions:
>   - pcm_lib.c: snd_pcm_hw_param_any
>   - pcm_lib.c: snd_pcm_hw_params_any
>   - pcm_lib.c: snd_pcm_hw_param_setinteger

Ack.

>   - pcm_misc.c: snd_pcm_format_cpu_endian
>   - pcm_misc.c: snd_pcm_format_size

They are used by drivers which are not merged to kernel yet.
Anyway, I moved the former one to a macro, and export the latter.

>   - seq/seq_midi_event.c: snd_midi_event_init
>   - seq/seq_midi_event.c: snd_midi_event_resize_buffer
>   - seq/seq_virmidi.c: snd_virmidi_receive

Ack.

>   - timer.c: snd_timer_system_resolution

This one can be killed.  The value is defined in the timer
definition.

> - remove the following unneeded EXPORT_SYMBOL's:
>   - pcm_lib.c: snd_interval_muldivk
>   - pcm_lib.c: snd_interval_mulkdiv
>   - pcm_lib.c: snd_interval_div
>   - pcm_lib.c: snd_pcm_hw_params
>   - pcm.c: snd_pcm_start

Ack.

>   - pcm.c: snd_pcm_suspend

I'd like to keep it global.

>   - rawmidi.c: snd_rawmidi_drop_output
>   - rawmidi.c: snd_rawmidi_drain_input
>   - rawmidi.c: snd_rawmidi_info

Let's keep them.  Rawmidi can be referred from out-of-kernel drivers.

>   - seq/seq_midi_event.c: snd_midi_event_resize_buffer
>   - seq/seq_midi_event.c: snd_midi_event_init
>   - seq/seq_virmidi.c: snd_virmidi_receive

Ack.

>   - timer.c: snd_timer_continue

Let's keep this, too.  This might be referred.

>   - timer.c: snd_timer_system_resolution
>   - sound.c: snd_device_free_all

Ack.


I'll fix the above on ALSA tree.


Thanks.


Takashi