From: Takashi Iwai <tiwai@suse.de>
To: Connor McAdams <conmanx360@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/20] ALSA: hda/ca0132 - Add bass redirection controls.
Date: Sat, 22 Aug 2020 18:17:41 +0200 [thread overview]
Message-ID: <s5h4koubqoq.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200821185239.26133-6-conmanx360@gmail.com>
On Fri, 21 Aug 2020 20:52:22 +0200,
Connor McAdams wrote:
>
> +static int ca0132_alt_add_bass_redirection_crossover(struct hda_codec *codec)
> +{
> + const char *namestr = "Output: Bass Redirection Playback Volume";
> + struct snd_kcontrol_new knew =
> + HDA_CODEC_VOLUME_MONO(namestr, BASS_REDIRECTION_XOVER, 1, 0,
> + HDA_OUTPUT);
This is no ideal name string for a control element, too.
Better to omit "Output:" prefix at least.
thanks,
Takashi
next prev parent reply other threads:[~2020-08-22 16:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 18:52 [PATCH 00/20] ALSA: hda/ca0132 - Add AE-7 support/Control cleanup Connor McAdams
2020-08-21 18:52 ` [PATCH 01/20] ALSA: hda/ca0132 - Cleanup ca0132_mmio_init function Connor McAdams
2020-08-21 18:52 ` [PATCH 02/20] ALSA: hda/ca0132 - Add speaker tuning initialization commands Connor McAdams
2020-08-21 18:52 ` [PATCH 03/20] ALSA: hda/ca0132 - Add surround channel config control Connor McAdams
2020-08-22 16:12 ` Takashi Iwai
2020-08-21 18:52 ` [PATCH 04/20] ALSA: hda/ca0132 - Add full-range speaker selection controls Connor McAdams
2020-08-21 18:52 ` [PATCH 05/20] ALSA: hda/ca0132 - Add bass redirection controls Connor McAdams
2020-08-22 16:17 ` Takashi Iwai [this message]
2020-08-21 18:52 ` [PATCH 06/20] ALSA: hda/ca0132 - Remove surround output selection Connor McAdams
2020-08-21 18:52 ` [PATCH 07/20] ALSA: hda/ca0132 - Clean up ca0132_alt_out_select Connor McAdams
2020-08-21 18:52 ` [PATCH 08/20] ALSA: hda/ca0132 - Add quirk output selection structures Connor McAdams
2020-08-21 18:52 ` [PATCH 09/20] ALSA: hda/ca0132 - Fix Recon3D Center/LFE output Connor McAdams
2020-08-21 18:52 ` [PATCH 10/20] ALSA: hda/ca0132 - Add new quirk ID for SoundBlaster AE-7 Connor McAdams
2020-08-21 18:52 ` [PATCH 11/20] ALSA: hda/ca0132 - Add SoundBlaster AE-7 pincfg Connor McAdams
2020-08-21 18:52 ` [PATCH 12/20] ALSA: hda/ca0132 - Set AE-7 bools and select mixer Connor McAdams
2020-08-21 18:52 ` [PATCH 13/20] ALSA: hda/ca0132 - Add ca0132_mmio_init data for SoundBlaster AE-7 Connor McAdams
2020-08-21 18:52 ` [PATCH 14/20] ALSA: hda/ca0132 - Add pre-init function " Connor McAdams
2020-08-21 18:52 ` [PATCH 15/20] ALSA: hda/ca0132 - Add init data " Connor McAdams
2020-08-21 18:52 ` [PATCH 16/20] ALSA: hda/ca0132 - Add DSP setup functions for AE-7 Connor McAdams
2020-08-21 18:52 ` [PATCH 17/20] ALSA: hda/ca0132 - Add output selection for SoundBlaster AE-7 Connor McAdams
2020-08-21 18:52 ` [PATCH 18/20] ALSA: hda/ca0132 - Add AE-7 microphone selection commands Connor McAdams
2020-08-21 18:52 ` [PATCH 19/20] ALSA: hda/ca0132 - Add AE-7 custom controls Connor McAdams
2020-08-21 18:52 ` [PATCH 20/20] ALSA: hda/ca0132 - Add AE-7 exit commands Connor McAdams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4koubqoq.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=conmanx360@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox