From: Takashi Iwai <tiwai@suse.de>
To: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
gregkh@linuxfoundation.org, alsa-devel@alsa-project.org,
linux-scsi@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 2/4] sound: isa: sscape: Use correct format identifier for size_t
Date: Mon, 11 Apr 2016 15:54:05 +0200 [thread overview]
Message-ID: <s5h4mb845fm.wl-tiwai@suse.de> (raw)
In-Reply-To: <903e7f51989907f3de2159efb99bd65bf3dc30f7.1460379702.git.vilhelm.gray@gmail.com>
On Mon, 11 Apr 2016 15:25:52 +0200,
William Breathitt Gray wrote:
>
> The 'size' member of a struct firmware is passed to snd_printk with a
> respective format string using the %d identifier. The 'size' member is
> of type size_t, but format identifier %d indicates a signed int data
> type. This patch replaces the %d format identifier with the correct %zu
> format identifier for size_t data types.
>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
This is basically irrelevant from ISA issue you're trying to solve, so
I'm going to apply this one individually to my tree.
thanks,
Takashi
> ---
> sound/isa/sscape.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c
> index 7b248cd..fdcfa29 100644
> --- a/sound/isa/sscape.c
> +++ b/sound/isa/sscape.c
> @@ -591,7 +591,7 @@ static int sscape_upload_microcode(struct snd_card *card, int version)
> }
> err = upload_dma_data(sscape, init_fw->data, init_fw->size);
> if (err == 0)
> - snd_printk(KERN_INFO "sscape: MIDI firmware loaded %d KBs\n",
> + snd_printk(KERN_INFO "sscape: MIDI firmware loaded %zu KBs\n",
> init_fw->size >> 10);
>
> release_firmware(init_fw);
> --
> 2.7.3
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
next prev parent reply other threads:[~2016-04-11 13:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 13:25 [PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option William Breathitt Gray
2016-04-11 13:25 ` [PATCH 1/4] pnp: pnpbios: Add explicit X86_32 dependency to PNPBIOS William Breathitt Gray
2016-04-22 23:51 ` Rafael J. Wysocki
2016-04-23 14:53 ` William Breathitt Gray
2016-05-01 15:52 ` William Breathitt Gray
2016-04-11 13:25 ` [PATCH 2/4] sound: isa: sscape: Use correct format identifier for size_t William Breathitt Gray
2016-04-11 13:54 ` Takashi Iwai [this message]
2016-04-11 13:25 ` [PATCH 3/4] scsi: ultrastor: Use correct format identifier for kernel pointer William Breathitt Gray
2016-04-11 13:25 ` [PATCH 4/4] isa: Remove the ISA_BUS Kconfig option William Breathitt Gray
2016-04-13 7:26 ` [PATCH 0/4] Decouple X86_32 dependency from the ISA " Ingo Molnar
2016-04-13 12:15 ` William Breathitt Gray
2016-04-13 14:38 ` Ingo Molnar
2016-04-13 14:48 ` William Breathitt Gray
2016-04-13 15:18 ` Greg KH
2016-05-01 16:17 ` William Breathitt Gray
2016-05-01 21:25 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4mb845fm.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vilhelm.gray@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox