From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DA30C43441 for ; Thu, 22 Nov 2018 22:20:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E72C920685 for ; Thu, 22 Nov 2018 22:20:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E72C920685 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392502AbeKWJBa (ORCPT ); Fri, 23 Nov 2018 04:01:30 -0500 Received: from mx2.suse.de ([195.135.220.15]:51408 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1733200AbeKWJB3 (ORCPT ); Fri, 23 Nov 2018 04:01:29 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id D1878AF62; Thu, 22 Nov 2018 22:20:04 +0000 (UTC) Date: Thu, 22 Nov 2018 23:20:04 +0100 Message-ID: From: Takashi Iwai To: "Borislav Petkov" Cc: "Vasily Khoruzhick" , "Linux-ALSA" , "Arnd Bergmann" , "Maxime Ripard" , "Chen-Yu Tsai" , "Liam Girdwood" , "Mark Brown" , "arm-linux" , "Jaroslav Kysela" , "linux-kernel" Subject: Re: [PATCH] ASoC: sunxi: rename SND_SUN8I_ADDA_PR_REGMAP In-Reply-To: <20181122212905.GA13187@zn.tnic> References: <20181102153406.1528053-1-arnd@arndb.de> <13542843.KjxkD9786N@anarsoul-thinkpad> <20181122212905.GA13187@zn.tnic> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Nov 2018 22:29:05 +0100, Borislav Petkov wrote: > > On Fri, Nov 02, 2018 at 03:06:59PM -0700, Vasily Khoruzhick wrote: > > On Fri, Nov 2, 2018 at 3:04 PM Arnd Bergmann wrote: > > > > > > On 11/2/18, Vasily Khoruzhick wrote: > > > > On Friday, November 2, 2018 8:33:40 AM PDT Arnd Bergmann wrote: > > > >> The newly added SND_SUN50I_CODEC_ANALOG driver selects a nonexisting > > > >> symbol SND_SUNXI_ADDA_PR_REGMAP, which was evidently intended to replace > > > >> SND_SUN8I_ADDA_PR_REGMAP, but since they are now mismatched, we can run > > > >> into link errors for some configurations: > > > >> > > > >> sound/soc/sunxi/sun50i-codec-analog.o: In function > > > >> `sun50i_codec_analog_probe': sun50i-codec-analog.c:(.text+0x62): > > > >> undefined > > > >> reference to `sun8i_adda_pr_regmap_init' > > > >> > > > >> The new name appears to be more sensible, and as the symbol is hidden, > > > >> there are no downsides in the rename, so use that consistently now. > > > > > > > > Maxime asked it to be SND_SUN8I_ADDA_PR_REGMAP, and also it would be easier > > > > to > > > > fix it my renaming last remaining SND_SUNXI_ADDA_PR_REGMAP to > > > > SND_SUN8I_ADDA_PR_REGMAP. > > > > > > Sure, I don't care either way. Please send a patch to do that then. > > > > Will do tonight. > > Is that patch coming up or on its way somewhere? > > I still hit randconfig build failures: > > ERROR: "sun8i_adda_pr_regmap_init" [sound/soc/sunxi/sun50i-codec-analog.ko] undefined! > make[1]: *** [__modpost] Error 1 > make: *** [modules] Error 2 It's been in Mark's asoc tree. Mark, could you send a pull request? It might be too late for rc4, but sooner, better. thanks, Takashi