From: Takashi Iwai <tiwai@suse.de>
To: " Gustavo A. R. Silva " <gustavo@embeddedor.com>
Cc: "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: mixart_core: Mark expected switch fall-through
Date: Thu, 09 Aug 2018 08:52:23 +0200 [thread overview]
Message-ID: <s5h600kf2vs.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180808221148.GA1864@embeddedor.com>
On Thu, 09 Aug 2018 00:11:48 +0200,
Gustavo A. R. Silva wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that in this particular case, I replaced the code comment with
> a proper "fall through" annotation, which is what GCC is expecting
> to find.
>
> Addresses-Coverity-ID: 114889 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied, thanks.
Takashi
prev parent reply other threads:[~2018-08-09 6:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 22:11 [PATCH] ALSA: mixart_core: Mark expected switch fall-through Gustavo A. R. Silva
2018-08-09 6:52 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h600kf2vs.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox