From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754593Ab0G1JyH (ORCPT ); Wed, 28 Jul 2010 05:54:07 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56695 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752934Ab0G1JyE (ORCPT ); Wed, 28 Jul 2010 05:54:04 -0400 Date: Wed, 28 Jul 2010 11:54:01 +0200 Message-ID: From: Takashi Iwai To: Axel Lin Cc: linux-kernel , Jaroslav Kysela , Eliot Blennerhassett Subject: Re: [PATCH] hpimsgx: fix wrong sizeof In-Reply-To: <1280307522.28099.1.camel@mola> References: <1280307522.28099.1.camel@mola> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 28 Jul 2010 16:58:42 +0800, Axel Lin wrote: > > The correct size should be sizeof(gRESP_HPI_SUBSYS_FIND_ADAPTERS), > sizeof(&gRESP_HPI_SUBSYS_FIND_ADAPTERS) is incorrect. > > Signed-off-by: Axel Lin Applied now. Thanks. Takashi > --- > sound/pci/asihpi/hpimsgx.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/pci/asihpi/hpimsgx.c b/sound/pci/asihpi/hpimsgx.c > index 2ee90dc..f01ab96 100644 > --- a/sound/pci/asihpi/hpimsgx.c > +++ b/sound/pci/asihpi/hpimsgx.c > @@ -741,7 +741,7 @@ static void HPIMSGX__reset(u16 adapter_index) > hpi_init_response(&hr, HPI_OBJ_SUBSYSTEM, > HPI_SUBSYS_FIND_ADAPTERS, 0); > memcpy(&gRESP_HPI_SUBSYS_FIND_ADAPTERS, &hr, > - sizeof(&gRESP_HPI_SUBSYS_FIND_ADAPTERS)); > + sizeof(gRESP_HPI_SUBSYS_FIND_ADAPTERS)); > > for (adapter = 0; adapter < HPI_MAX_ADAPTERS; adapter++) { > > -- > 1.5.4.3 > > >