Re: [PATCH] Re: ALSA HDA Intel stoped to work in 2.6.16-*

[Takashi Iwai <tiwai@suse.de>]

At Sat, 7 Mar 2009 19:00:44 +0100,
Rafael J. Wysocki wrote:
> 
> (adding CCs).
> 
> Usually, sending such things to the LKML alone doesn't really work.  Please
> always send a CC to the relevant subsystem maintainer.

Yep, thanks.

A comment about this change below...

> On Saturday 07 March 2009, Daniel Gimpelevich wrote:
> > At Mon, 6 Mar 2006 15:16:15 +0100,
> > Takashi Iwai wrote:
> > 
> > > At Sat, 4 Mar 2006 15:51:14 +0100,
> > > Adrian Bunk wrote:
> > >> 
> > >> On Sat, Mar 04, 2006 at 02:29:02AM -0300, Otavio Salvador wrote:
> > >> > Takashi Iwai <tiwai@suse.de> writes:
> > >> > 
> > >> > > Are you sure that your device has PCI SUB-system id 8086:2668 ?
> > >> > 
> > >> > oh no! Sorry!
> > >> > 
> > >> > 0000:00:1b.0 0403: 8086:2668 (rev 04)
> > >> >         Subsystem: 152d:0729
> > >> >                    ^^^^^^^^^
> > >> 
> > >> Can you make a patch with the correct id test whether it fixes your 
> > >> problem (without model=basic)?
> > > 
> > > This one should work for his device.
> > > 
> > > 
> > > Takashi
> > > ===
> > > 
> > > [PATCH] Add default entry for CTL Travel Master U553W
> > > 
> > > Added the default entry of ALC880 configuration table for
> > > CTL Travel Master U553W.
> > > 
> > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > > 
> > > ---
> > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> > > index b767552..d5cd3a1 100644
> > > --- a/sound/pci/hda/patch_realtek.c
> > > +++ b/sound/pci/hda/patch_realtek.c
> > > @@ -2948,6 +2948,8 @@ static struct hda_board_config alc260_cf
> > >       { .modelname = "basic", .config = ALC260_BASIC },
> > >       { .pci_subvendor = 0x104d, .pci_subdevice = 0x81bb,
> > >         .config = ALC260_BASIC }, /* Sony VAIO */
> > > +     { .pci_subvendor = 0x152d, .pci_subdevice = 0x0729,
> > > +       .config = ALC260_BASIC }, /* CTL Travel Master U553W */
> > >       { .modelname = "hp", .config = ALC260_HP },
> > >       { .pci_subvendor = 0x103c, .pci_subdevice = 0x3010, .config = ALC260_HP },
> > >       { .pci_subvendor = 0x103c, .pci_subdevice = 0x3011, .config = ALC260_HP },
> > 
> > It has been three years since the above patch was posted with a request for
> > testing. No testing reply ever appeared, and the patch was committed as
> > submitted. On the relevant hardware, I determined the patch to be incorrect.

Daniel, how "incorrect" do you mean exactly?

As you cited, the above patch was added for the request for the
specific model, so the patch itself is correct per definition.  What
wrong could be the choice of the model option by the original poster,
which I cannot judge.

Of course I have no objection to fix the model entry at all, but I
need a more proper justification.


thanks,

Takashi