Re: [Fwd: [PATCH] [PNP][RFC] Suspend support for PNP bus.]

[Takashi Iwai <tiwai@suse.de>]

At Tue, 29 Nov 2005 20:49:44 +0100,
Pierre Ossman wrote:
> 
> Andrew Morton wrote:
> 
> >Pierre Ossman <drzeus-list@drzeus.cx> wrote:
> >  
> >
> >>Andrew Morton wrote:
> >>
> >>    
> >>
> >>>Pierre Ossman <drzeus-list@drzeus.cx> wrote:
> >>> 
> >>>
> >>>      
> >>>
> >>>>Add support for suspending devices connected to the PNP bus. New
> >>>>callbacks are added for the drivers and the PNP hardware layer is
> >>>>told to disable the device during the suspend.
> >>>>   
> >>>>
> >>>>        
> >>>>
> >>>The ALSA guys have gone off and implemented their own version of this, and
> >>>it's a bit different.   I'll need to drop this patch now.
> >>>
> >>>Please review http://www.zip.com.au/~akpm/linux/patches/stuff/git-alsa.patch, sort
> >>>things out?
> >>> 
> >>>
> >>>      
> >>>
> >>That things is huge! Do the ALSA guys perhaps have a patch with just the
> >>PnP bit in it?
> >>
> >>    
> >>
> >
> >http://www.kernel.org/git/gitweb.cgi?p=linux/kernel/git/perex/alsa-current.git;a=commitdiff;h=5353d906effe648dd20899fe61ecb6982ad93cdd
> >
> >  
> >
> 
> That patch is a bit dumber than mine. It doesn't do anything but call
> the driver supplied suspend/resume function, i.e. no PnP handling during
> suspend. It does handle cards though, something my patch doesn't do.
> Perhaps a combination of the two is acceptable to the ALSA crowd?

Yep, my implementation is only for very basic things and may lack of
many stuff.  Any fix would be welcome.


Takashi