From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C6B5C64EBC for ; Thu, 4 Oct 2018 20:55:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 516BA2087D for ; Thu, 4 Oct 2018 20:55:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 516BA2087D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727953AbeJEDuu (ORCPT ); Thu, 4 Oct 2018 23:50:50 -0400 Received: from mx2.suse.de ([195.135.220.15]:34254 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727536AbeJEDuu (ORCPT ); Thu, 4 Oct 2018 23:50:50 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B2AEAAED2; Thu, 4 Oct 2018 20:55:46 +0000 (UTC) Date: Thu, 04 Oct 2018 22:55:46 +0200 Message-ID: From: Takashi Iwai To: "Nicolas Huaman" Cc: "Jaroslav Kysela" , , Subject: Re: [PATCH] ALSA: usb-audio: update quirk for B&W PX to remove microphone In-Reply-To: <20181004144205.18153-1-nicolas@herochao.de> References: <20181004144205.18153-1-nicolas@herochao.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 04 Oct 2018 16:42:05 +0200, Nicolas Huaman wrote: > > A quirk in snd-usb-audio was added to automate setting sample rate to > 4800k and remove the previously exposed nonfunctional microphone for > the Bowers & Wilkins PX: > commit 240a8af929c7c57dcde28682725b29cf8474e8e5 > https://lore.kernel.org/patchwork/patch/919689/ > > However the headphones where updated shortly after that to remove the > unintentional microphone functionality. I guess because of this the > headphones now crash when connecting them via USB while the quirk is > active. Dmesg: > > snd-usb-audio: probe of 2-3:1.0 failed with error -22 > usb 2-3: 2:1: cannot get min/max values for control 2 (id 2) > > This patch removes the microfone and allows the headphones to connect > and work out of the box. It is based on the current mainline kernel > and successfully applied an tested on my machine (4.18.10.arch1-1). > > Signed-off-by: Nicolas Huaman Thanks, that looks much better now, and I can apply it. But just to be sure: is any quirk required after the firmware update on this device at all? What happens if you remove the whole quirk? If this modified quirk is still mandatory, I'll happily apply the patch. thanks, Takashi