From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753671AbdK0TvY (ORCPT <rfc822;w@1wt.eu>);
        Mon, 27 Nov 2017 14:51:24 -0500
Received: from mx2.suse.de ([195.135.220.15]:54333 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752990AbdK0TvX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Nov 2017 14:51:23 -0500
Date: Mon, 27 Nov 2017 20:51:20 +0100
Message-ID: <s5h7eubmrev.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Takashi Sakamoto" <o-takashi@sakamocchi.jp>
Cc: <alsa-devel@alsa-project.org>, "Colin King" <colin.king@canonical.com>,
        "Jaroslav Kysela" <perex@perex.cz>, <wharms@bfs.de>,
        <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: drivers: make array 'names' const, reduces object code size
In-Reply-To: <11bbcc13-2ff9-68ed-6331-f65c2247b4db@sakamocchi.jp>
References: <20171127125851.10076-1-colin.king@canonical.com>
        <11bbcc13-2ff9-68ed-6331-f65c2247b4db@sakamocchi.jp>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 27 Nov 2017 18:34:17 +0100,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> On Nov 27 2017 21:58, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Don't populate array 'names' on the stack but instead make them static.
> > Makes the object code smaller by 50 bytes:
> >
> > Before:
> >     text	   data	    bss	    dec	    hex	filename
> >    21237	   9192	   1120	  31549	   7b3d	linux/sound/drivers/dummy.o
> >
> > After:
> >     text	   data	    bss	    dec	    hex	filename
> >    21095	   9280	   1120	  31495	   7b07	linux/sound/drivers/dummy.o
> >
> > (gcc version 7.2.0 x86_64)
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> >   sound/drivers/dummy.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sound/drivers/dummy.c b/sound/drivers/dummy.c
> > index 7b2b1f766b00..69db45bc0197 100644
> > --- a/sound/drivers/dummy.c
> > +++ b/sound/drivers/dummy.c
> > @@ -830,7 +830,7 @@ static int snd_dummy_capsrc_put(struct snd_kcontrol *kcontrol, struct snd_ctl_el
> >   static int snd_dummy_iobox_info(struct snd_kcontrol *kcontrol,
> >   				struct snd_ctl_elem_info *info)
> >   {
> > -	const char *const names[] = { "None", "CD Player" };
> > +	static const char *const names[] = { "None", "CD Player" };
> >     	return snd_ctl_enum_info(info, 1, 2, names);
> >   }
> 
> Total size of snd-dummy.ko increases but this patch has an advantage
> to have the symbol in read-only section.

The total size decreases :)


Takashi