[2.6 PATCH] front buttons wouldn't mute ESS Maestro

[2.6 PATCH] front buttons wouldn't mute ESS Maestro

[Samuel Thibault]

Hi,

Here is a small fix to enable muting ESS Maestro sound card thanks to
the up/down buttons: when has reached the driver's minimum (! this is
something like -dB value), just mute.
(It was working in OSS driver, but not in ALSA)

--- linux-2.6.7-orig/sound/pci/es1968.c	2004-07-25 00:06:20.000000000 +0200
+++ linux/sound/pci/es1968.c	2004-07-25 00:29:54.000000000 +0200
@@ -1990,6 +1990,8 @@
 			if ((val & 0xff00) < 0x1f00)
 				val += 0x0100;
 		}
+		if (val == 0x1f1f)
+			val |= 0x8000;
 		snd_ac97_write_cache(chip->ac97, AC97_MASTER, val);
 		snd_ctl_notify(chip->card, SNDRV_CTL_EVENT_MASK_VALUE,
 			       &chip->master_volume->id);


Regards,
Samuel

Re: [2.6 PATCH] front buttons wouldn't mute ESS Maestro

[Takashi Iwai]

At Sun, 25 Jul 2004 00:41:29 +0200,
Samuel Thibault wrote:
> 
> Hi,
> 
> Here is a small fix to enable muting ESS Maestro sound card thanks to
> the up/down buttons: when has reached the driver's minimum (! this is
> something like -dB value), just mute.
> (It was working in OSS driver, but not in ALSA)

Thanks for the patch.  

ALSA doesn't unmute automatically, so I'm afraid that we'll need a
code for that, too.


Takashi

Re: [2.6 PATCH] front buttons wouldn't mute ESS Maestro

[Samuel Thibault]

Hi,

Le mer 28 jui 2004 à 19:32:43 +0200, Takashi Iwai a tapoté sur son clavier :
> ALSA doesn't unmute automatically, so I'm afraid that we'll need a
> code for that, too.

Well, that's not necessarily a need: provided that the *mix program you
uses does unmute, there's no trouble: I tested aumix, which does fine,
and alsamixer, which indeed doesn't unmute, but has a key for this, and
it fact, in might be useful to change volume level while muted, and then
suddenly unmute.

Regards,
Samuel

Re: [2.6 PATCH] front buttons wouldn't mute ESS Maestro

[Takashi Iwai]

At Wed, 28 Jul 2004 20:37:14 +0200,
Samuel Thibault wrote:
> 
> Hi,
> 
> Le mer 28 jui 2004 à 19:32:43 +0200, Takashi Iwai a tapoté sur son clavier :
> > ALSA doesn't unmute automatically, so I'm afraid that we'll need a
> > code for that, too.
> 
> Well, that's not necessarily a need: provided that the *mix program you
> uses does unmute, there's no trouble: I tested aumix, which does fine,
> and alsamixer, which indeed doesn't unmute, but has a key for this, and
> it fact, in might be useful to change volume level while muted, and then
> suddenly unmute.

Then I feel it's somehow incosnsitent to mute at the lowest level but
not unmute after that.
For me it's ok to do muting/unmuting automatically per volume level.
It's just a question of user-friendliness.


Takashi