From: Takashi Iwai <tiwai@suse.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-kernel@vger.kernel.org,
viro@parcelfarce.linux.theplanet.co.uk, perex@suse.cz,
torvalds@osdl.org
Subject: Re: [RFC] ASLA design, depth of code review and lack thereof
Date: Mon, 07 Jun 2004 15:57:51 +0200 [thread overview]
Message-ID: <s5h7juj4gio.wl@alsa2.suse.de> (raw)
In-Reply-To: <40C471FC.3000802@pobox.com>
At Mon, 07 Jun 2004 09:47:40 -0400,
Jeff Garzik wrote:
>
> Takashi Iwai wrote:
> > At Fri, 04 Jun 2004 19:37:54 -0400,
> > Jeff Garzik wrote:
> >
> >>
> >>While we're bitching about ALSA, can we please kill the
> >>subsystem-specific malloc and "magic cast" wrappers?
> >>This debug machinery is better done elsewhere...
> >
> >
> > Of course we can remove kmalloc/vmalloc wrappers for cast checking
> > once when the kernel core provides a similar debugging mechanism.
> > Do you know any alternative?
>
>
> CONFIG_DEBUG_SLAB and CONFIG_DEBUG_PAGEALLOC. Other stuff should go
> into ALSA developer trees or use of a debugger, not be in mainline
> kernel code.
They're nice but they don't provide "cast checking", no?
The main purpose of the magic_* stuffs in ALSA is to check the cast of
the void pointer back to the original data type, which the compiler
can't check.
Maybe we can implement only this "magic" check separetly and get rid
of allocation checks, but I'm not sure whether it's worthy to do
that.
Takashi
next prev parent reply other threads:[~2004-06-07 13:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-04 23:08 [RFC] ASLA design, depth of code review and lack thereof viro
2004-06-04 23:14 ` viro
2004-06-04 23:29 ` Linus Torvalds
2004-06-05 0:04 ` viro
2004-06-07 13:14 ` Takashi Iwai
2004-06-07 22:40 ` viro
2004-06-08 12:49 ` Takashi Iwai
2004-06-07 13:10 ` Takashi Iwai
2004-06-04 23:37 ` Jeff Garzik
2004-06-07 13:24 ` Takashi Iwai
2004-06-07 13:47 ` Jeff Garzik
2004-06-07 13:57 ` Takashi Iwai [this message]
2004-06-07 14:05 ` Jeff Garzik
2004-06-07 14:12 ` Takashi Iwai
2004-06-07 14:18 ` Russell King
2004-06-08 13:27 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h7juj4gio.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
--cc=torvalds@osdl.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox