From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=JGWI=D6=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id ADC55C388F9
	for <linux-kernel@archiver.kernel.org>; Fri, 23 Oct 2020 12:59:12 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 6779D20E65
	for <linux-kernel@archiver.kernel.org>; Fri, 23 Oct 2020 12:59:12 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S371946AbgJWM7K (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Fri, 23 Oct 2020 08:59:10 -0400
Received: from mx2.suse.de ([195.135.220.15]:43486 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S371406AbgJWM7J (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 23 Oct 2020 08:59:09 -0400
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.221.27])
        by mx2.suse.de (Postfix) with ESMTP id E1783AFC3;
        Fri, 23 Oct 2020 12:59:08 +0000 (UTC)
Date:   Fri, 23 Oct 2020 14:59:08 +0200
Message-ID: <s5h8sbx85er.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc:     tiwai@suse.com, Jaroslav Kysela <perex@perex.cz>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        "moderated list:SOUND" <alsa-devel@alsa-project.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] ALSA: hda: Stop mangling PCI MSI
In-Reply-To: <6562A60B-C27C-4912-94AE-6A23839DABF4@canonical.com>
References: <20201023102340.25494-1-kai.heng.feng@canonical.com>
        <20201023102340.25494-2-kai.heng.feng@canonical.com>
        <s5himb189by.wl-tiwai@suse.de>
        <6562A60B-C27C-4912-94AE-6A23839DABF4@canonical.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 23 Oct 2020 14:53:08 +0200,
Kai-Heng Feng wrote:
> 
> 
> 
> > On Oct 23, 2020, at 19:34, Takashi Iwai <tiwai@suse.de> wrote:
> > 
> > On Fri, 23 Oct 2020 12:23:36 +0200,
> > Kai-Heng Feng wrote:
> >> 
> >> @@ -1038,14 +1036,6 @@ static int azx_suspend(struct device *dev)
> >> 		__azx_runtime_suspend(chip);
> >> 	else
> >> 		pm_runtime_force_suspend(dev);
> >> -	if (bus->irq >= 0) {
> >> -		free_irq(bus->irq, chip);
> >> -		bus->irq = -1;
> >> -		chip->card->sync_irq = -1;
> >> -	}
> > 
> > This release of irq has nothing to do with MSI.  There has been PCI
> > controllers that assign to a different IRQ line after the resume.
> 
> Can this issue happened before commit 41017f0cac925 ("[PATCH] PCI: MSI(X) save/restore for suspend/resume") was merged?

It's not about MSI.  The IRQ number itself may change after the
resume.

But I guess it's hard to prove it; the system was tad old, and I don't
know who own it now.


Takashi