From: Takashi Iwai <tiwai@suse.de>
To: "Geert Uytterhoeven" <geert@linux-m68k.org>
Cc: "Clemens Ladisch" <clemens@ladisch.de>,
"Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: firewire-digi00x: Drop bogus const type qualifier on dot_scrt()
Date: Tue, 09 Feb 2016 12:17:26 +0100 [thread overview]
Message-ID: <s5h8u2uxhdl.wl-tiwai@suse.de> (raw)
In-Reply-To: <1454854455-20894-1-git-send-email-geert@linux-m68k.org>
On Sun, 07 Feb 2016 15:14:15 +0100,
Geert Uytterhoeven wrote:
>
> sound/firewire/digi00x/amdtp-dot.c:67: warning: type qualifiers ignored on function return type
>
> Drop the bogus "const" type qualifier on the return type of dot_scrt()
> to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied now, thanks.
Takashi
> ---
> sound/firewire/digi00x/amdtp-dot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/firewire/digi00x/amdtp-dot.c b/sound/firewire/digi00x/amdtp-dot.c
> index b02a5e8cad448c40..0ac92aba5bc1c9a4 100644
> --- a/sound/firewire/digi00x/amdtp-dot.c
> +++ b/sound/firewire/digi00x/amdtp-dot.c
> @@ -63,7 +63,7 @@ struct amdtp_dot {
> #define BYTE_PER_SAMPLE (4)
> #define MAGIC_DOT_BYTE (2)
> #define MAGIC_BYTE_OFF(x) (((x) * BYTE_PER_SAMPLE) + MAGIC_DOT_BYTE)
> -static const u8 dot_scrt(const u8 idx, const unsigned int off)
> +static u8 dot_scrt(const u8 idx, const unsigned int off)
> {
> /*
> * the length of the added pattern only depends on the lower nibble
> --
> 1.9.1
>
>
prev parent reply other threads:[~2016-02-09 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-07 14:14 [PATCH] ALSA: firewire-digi00x: Drop bogus const type qualifier on dot_scrt() Geert Uytterhoeven
2016-02-08 11:22 ` Takashi Sakamoto
2016-02-09 11:17 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h8u2uxhdl.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox