Re: [PATCH 1/2] ALSA: Kconfig: add config menu for reduced memory footprint

[Takashi Iwai <tiwai@suse.de>]

At Tue, 26 May 2015 19:04:24 +0800,
Jie Yang wrote:
> 
> For some embedded devices, we need reduce code size and data
> footprint as much as possible, e.g. disabling procfs, hw/sw
> params refinement, mmap, dpcm, dapm, compressed API...
> 
> Here add root config menu for those configuration, and
> disable procfs once reduced memory footprint is selected.
> 
> Signed-off-by: Jie Yang <yang.jie@intel.com>
> ---
>  sound/Kconfig | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/sound/Kconfig b/sound/Kconfig
> index 5a240e0..6760dfa 100644
> --- a/sound/Kconfig
> +++ b/sound/Kconfig
> @@ -68,6 +68,22 @@ menuconfig SND
>  
>  if SND
>  
> +menuconfig SND_REDUCED_MEMORY_FOOTPRINT
> +	bool "Reduced Memory Footprint Support"
> +	default n
> +	help
> +	  Say 'Y' to enable Reduced Memory Footprint Support, which may
> +	  reduce code size and data footprint as much as possible.

I'd like to move this into sound/core.
Also, the kconfig name appears a bit too lengthy to me.

> +config SND_PROC_FS
> +	bool "Sound Proc FS Support"
> +	depends on PROC_FS && !SND_REDUCED_MEMORY_FOOTPRINT

This should be
	bool "Sound Proc FS Support" if !SND_REDUCED_MEMORY_FOOTPRINT
	depends on PROC_FS

In this way, this prompt would appear only when
SND_REDUCED_MEMORY_FOOTPRINT is set, i.e. only for experts.


thanks,

Takashi

> +	default y
> +	help
> +	  Say 'N' to disable Sound proc FS, which may reduce code size about
> +	  9KB on x86_64 platform.
> +	  If unsure say Y.
> +
>  source "sound/core/Kconfig"
>  
>  source "sound/drivers/Kconfig"
> -- 
> 1.9.1
>