public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>, Oliver Neukum <oneukum@suse.de>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] ACPI: Blacklist Win8 OSI for some HP laptop 2013 models
Date: Mon, 13 Jan 2014 12:33:26 +0100	[thread overview]
Message-ID: <s5h8uukuneh.wl%tiwai@suse.de> (raw)
In-Reply-To: <1935658.J9tLa335qc@vostro.rjw.lan>

At Mon, 13 Jan 2014 12:46:31 +0100,
Rafael J. Wysocki wrote:
> 
> On Monday, January 13, 2014 12:14:18 PM Takashi Iwai wrote:
> > The BIOS on recent HP laptops behaves differently with Win8 OSI,
> > e.g. no backlight control and no rfkill are available.  List them in
> > the blacklist as a workaround.
> > 
> > This patch tries to reduce the added items by matching "G1" suffix,
> > e.g. machines are named like "HP ProBook 430 G1".
> > 
> > Bugzilla: https://bugzilla.novell.com/show_bug.cgi?id=856294
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > ---
> > 
> > Rafael, could you check this?
> > If the problem were only about the backlight, we could fix differenly,
> > but BIOS on these machines seems to switching more other functions
> > like rfkill.
> 
> It looks like I have this patch in my linux-next branch.

OK, thanks!


Takashi

> 
> Thanks!
> 
> 
> >  drivers/acpi/blacklist.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 50 insertions(+)
> > 
> > diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
> > index 078c4f7fe2dd..40c91f5052ef 100644
> > --- a/drivers/acpi/blacklist.c
> > +++ b/drivers/acpi/blacklist.c
> > @@ -323,6 +323,56 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
> >  		     DMI_MATCH(DMI_PRODUCT_VERSION, "2349D15"),
> >  		},
> >  	},
> > +	{
> > +	.callback = dmi_disable_osi_win8,
> > +	.ident = "HP ProBook 2013 models",
> > +	.matches = {
> > +		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> > +		     DMI_MATCH(DMI_PRODUCT_NAME, "HP ProBook "),
> > +		     DMI_MATCH(DMI_PRODUCT_NAME, " G1"),
> > +		},
> > +	},
> > +	{
> > +	.callback = dmi_disable_osi_win8,
> > +	.ident = "HP EliteBook 2013 models",
> > +	.matches = {
> > +		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> > +		     DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook "),
> > +		     DMI_MATCH(DMI_PRODUCT_NAME, " G1"),
> > +		},
> > +	},
> > +	{
> > +	.callback = dmi_disable_osi_win8,
> > +	.ident = "HP ZBook 14",
> > +	.matches = {
> > +		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> > +		     DMI_MATCH(DMI_PRODUCT_NAME, "HP ZBook 14"),
> > +		},
> > +	},
> > +	{
> > +	.callback = dmi_disable_osi_win8,
> > +	.ident = "HP ZBook 15",
> > +	.matches = {
> > +		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> > +		     DMI_MATCH(DMI_PRODUCT_NAME, "HP ZBook 15"),
> > +		},
> > +	},
> > +	{
> > +	.callback = dmi_disable_osi_win8,
> > +	.ident = "HP ZBook 17",
> > +	.matches = {
> > +		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> > +		     DMI_MATCH(DMI_PRODUCT_NAME, "HP ZBook 17"),
> > +		},
> > +	},
> > +	{
> > +	.callback = dmi_disable_osi_win8,
> > +	.ident = "HP EliteBook 8780w",
> > +	.matches = {
> > +		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> > +		     DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8780w"),
> > +		},
> > +	},
> >  
> >  	/*
> >  	 * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.
> > 
> 
> -- 
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
> 

  reply	other threads:[~2014-01-13 11:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-13 11:14 [PATCH RESEND] ACPI: Blacklist Win8 OSI for some HP laptop 2013 models Takashi Iwai
2014-01-13 11:46 ` Rafael J. Wysocki
2014-01-13 11:33   ` Takashi Iwai [this message]
2014-01-14 16:12 ` Matthew Garrett
2014-01-14 16:33   ` Takashi Iwai
2014-01-14 16:36     ` Matthew Garrett
2014-01-14 16:43       ` Takashi Iwai
2014-01-14 16:44         ` Matthew Garrett
2014-01-14 16:42   ` Rafael J. Wysocki
2014-01-14 16:34     ` Matthew Garrett
2014-01-14 16:53       ` Rafael J. Wysocki
2014-01-14 16:42         ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h8uukuneh.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oneukum@suse.de \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox