From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S267350AbUG1RfO@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S267350AbUG1RfO (ORCPT <rfc822;willy@w.ods.org>);
	Wed, 28 Jul 2004 13:35:14 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267348AbUG1RfO
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 28 Jul 2004 13:35:14 -0400
Received: from cantor.suse.de ([195.135.220.2]:61317 "EHLO Cantor.suse.de")
	by vger.kernel.org with ESMTP id S267350AbUG1Re7 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 28 Jul 2004 13:34:59 -0400
Date: Wed, 28 Jul 2004 19:30:57 +0200
Message-ID: <s5h8yd411ke.wl@alsa2.suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Andrew Morton <akpm@osdl.org>, Andrew Chew <achew@nvidia.com>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.8-rc2] intel8x0.c to include CK804 audio support
In-Reply-To: <4105B947.1000106@pobox.com>
References: <DBFABB80F7FD3143A911F9E6CFD477B03F95EF@hqemmail02.nvidia.com>
	<20040726180601.3b88d166.akpm@osdl.org>
	<4105B947.1000106@pobox.com>
User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 15) (Security Through Obscurity) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

At Mon, 26 Jul 2004 22:09:11 -0400,
Jeff Garzik wrote:
> 
> Andrew Morton wrote:
> > "Andrew Chew" <achew@nvidia.com> wrote:
> > 
> >>I sincerely apologize about the mangled patch.  I'll be more careful
> >>next time (and check my mailer settings).
> > 
> > 
> > Is OK - you're in good company ;)
> > 
> > 
> >>The #ifdef was for consistency (I noticed that there were other IDs
> >>similarly defined in intel8x0.c).  I don't see why we'd need it, either.
> >>We should probably remove PCI_DEVICE_ID_NVIDIA_MCP2_AUDIO and
> >>PCI_DEVICE_ID_NVIDIA_MCP3_AUDIO #defines from intel8x0.c as well, as
> >>they're similarly redundant.  For that matter, why not remove all of the
> >>PCI_DEVICE_ID_* #defines from the intel8x0.c driver, and make sure the
> >>device IDs are defined in pci_ids.h.
> >>
> >>Want me to submit a patch for that?
> > 
> > 
> > Let's leave that up to Jeff.
> 
> Jaroslav and the ALSA guys...  no idea who maintains the ALSA i810 driver.
 
ALSA team ;)
I included the patch to ALSA tree.  Thanks.
Jaroslav will submit the patchset later.

> In any case, I think the device id constants are a waste, and have 
> stopped using the *_DEVICE_ID_* constants in my drivers.  The vendor id 
> is generally common across many drivers, but rarely does one care about 
> sharing arbitrary name<->arbitrary id mappings these days, when one 
> driver supports so many chips.

Well, I agree in general.  It would be still reasonable to define a
const when it appears more than once, though.


Takashi