From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A149C46470 for ; Wed, 8 Aug 2018 18:43:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5807E21798 for ; Wed, 8 Aug 2018 18:43:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5807E21798 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729704AbeHHVEW (ORCPT ); Wed, 8 Aug 2018 17:04:22 -0400 Received: from mx2.suse.de ([195.135.220.15]:46588 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727295AbeHHVEW (ORCPT ); Wed, 8 Aug 2018 17:04:22 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A7604AF68; Wed, 8 Aug 2018 18:43:23 +0000 (UTC) Date: Wed, 08 Aug 2018 20:43:22 +0200 Message-ID: From: Takashi Iwai To: "Connor McAdams" Cc: , "Alastair Bridgewater" , "Jaroslav Kysela" , "Takashi Sakamoto" , Subject: Re: [PATCH 00/11] Add Recon3D support + Driver cleanup In-Reply-To: <1533749663-8200-1-git-send-email-conmanx360@gmail.com> References: <1533749663-8200-1-git-send-email-conmanx360@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 08 Aug 2018 19:34:11 +0200, Connor McAdams wrote: > > This patch series adds support for the Recon3D PCI-E card. I have > personally tested it on a Recon3D that was sent to me, and included > that PCI ID in the quirk table. > > Much of this patch series renames Recon3Di functions to just r3d > because both cards behave similarly. All patches look well cooked. I applied all 11 patches now. > Aside from that, I do have a question- If the PCI ID's are included in > the Window's driver .inf file, would I be good to add them in as > quirks? Or should I wait for someone with the card to test it, and > then add it once I know it works on that specific card? Such a decision depends on the situation, and in the case of CA0132, we can take them, I suppose. The boards don't work properly without the explicit fixes, so it can't be worse, after all :) Thanks! Takashi