* [PATCH] [ALSA] sound: rme32.c irq enabling after spin_lock_irq
@ 2013-02-11 15:04 Denis Efremov
2013-02-11 15:31 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Denis Efremov @ 2013-02-11 15:04 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Denis Efremov, Bill Pemberton, linux-kernel
According to the other code in this driver and similar
code in rme96 it seems, that spin_lock_irq in
snd_rme32_capture_close function should be paired
with spin_unlock_irq.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
---
sound/pci/rme32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/rme32.c b/sound/pci/rme32.c
index 2450663..0ecd410 100644
--- a/sound/pci/rme32.c
+++ b/sound/pci/rme32.c
@@ -1017,7 +1017,7 @@ static int snd_rme32_capture_close(struct snd_pcm_substream *substream)
spin_lock_irq(&rme32->lock);
rme32->capture_substream = NULL;
rme32->capture_periodsize = 0;
- spin_unlock(&rme32->lock);
+ spin_unlock_irq(&rme32->lock);
return 0;
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [ALSA] sound: rme32.c irq enabling after spin_lock_irq
2013-02-11 15:04 [PATCH] [ALSA] sound: rme32.c irq enabling after spin_lock_irq Denis Efremov
@ 2013-02-11 15:31 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2013-02-11 15:31 UTC (permalink / raw)
To: Denis Efremov; +Cc: Bill Pemberton, linux-kernel
At Mon, 11 Feb 2013 19:04:06 +0400,
Denis Efremov wrote:
>
> According to the other code in this driver and similar
> code in rme96 it seems, that spin_lock_irq in
> snd_rme32_capture_close function should be paired
> with spin_unlock_irq.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
Thanks, applied (with Cc to stable, too).
Takashi
> ---
> sound/pci/rme32.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/rme32.c b/sound/pci/rme32.c
> index 2450663..0ecd410 100644
> --- a/sound/pci/rme32.c
> +++ b/sound/pci/rme32.c
> @@ -1017,7 +1017,7 @@ static int snd_rme32_capture_close(struct snd_pcm_substream *substream)
> spin_lock_irq(&rme32->lock);
> rme32->capture_substream = NULL;
> rme32->capture_periodsize = 0;
> - spin_unlock(&rme32->lock);
> + spin_unlock_irq(&rme32->lock);
> return 0;
> }
>
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-11 15:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-11 15:04 [PATCH] [ALSA] sound: rme32.c irq enabling after spin_lock_irq Denis Efremov
2013-02-11 15:31 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox