From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757602Ab3BKPbi (ORCPT ); Mon, 11 Feb 2013 10:31:38 -0500 Received: from cantor2.suse.de ([195.135.220.15]:36322 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756758Ab3BKPbh (ORCPT ); Mon, 11 Feb 2013 10:31:37 -0500 Date: Mon, 11 Feb 2013 16:31:36 +0100 Message-ID: From: Takashi Iwai To: Denis Efremov Cc: Bill Pemberton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] [ALSA] sound: rme32.c irq enabling after spin_lock_irq In-Reply-To: <1360595046-25004-1-git-send-email-yefremov.denis@gmail.com> References: <1360595046-25004-1-git-send-email-yefremov.denis@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 11 Feb 2013 19:04:06 +0400, Denis Efremov wrote: > > According to the other code in this driver and similar > code in rme96 it seems, that spin_lock_irq in > snd_rme32_capture_close function should be paired > with spin_unlock_irq. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Denis Efremov Thanks, applied (with Cc to stable, too). Takashi > --- > sound/pci/rme32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/rme32.c b/sound/pci/rme32.c > index 2450663..0ecd410 100644 > --- a/sound/pci/rme32.c > +++ b/sound/pci/rme32.c > @@ -1017,7 +1017,7 @@ static int snd_rme32_capture_close(struct snd_pcm_substream *substream) > spin_lock_irq(&rme32->lock); > rme32->capture_substream = NULL; > rme32->capture_periodsize = 0; > - spin_unlock(&rme32->lock); > + spin_unlock_irq(&rme32->lock); > return 0; > } > > -- > 1.8.1.2 >