From: Takashi Iwai <tiwai@suse.de>
To: "Yinghai Lu" <yhlu.kernel@gmail.com>
Cc: "David Miller" <davem@davemloft.net>,
matthew@wil.cx, arjan@linux.intel.com, greg@kroah.com,
James.Bottomley@hansenpartnership.com,
ksummit-2008-discuss@lists.linux-foundation.org,
dwmw2@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [Ksummit-2008-discuss] RFC: Moving firmware blobs out of the kernel.
Date: Fri, 30 May 2008 11:52:42 +0200 [thread overview]
Message-ID: <s5habi8ce51.wl%tiwai@suse.de> (raw)
In-Reply-To: <86802c440805291457r71340133pc413b7f1e78e5df3@mail.gmail.com>
At Thu, 29 May 2008 14:57:38 -0700,
Yinghai Lu wrote:
>
> On Thu, May 29, 2008 at 2:31 PM, David Miller <davem@davemloft.net> wrote:
> > From: "Yinghai Lu" <yhlu.kernel@gmail.com>
> > Date: Thu, 29 May 2008 13:55:16 -0700
> >
> >> driver should check fw version...
> >
> > This alone is not a reason to rip the firmware out into a seperate
> > tree. And I am absolutely not convinced that the cases where this
> > matters all universally even use firmware versions.
> >
> > I've installed the wrong ipw2200 on several occaisions.
> >
> > Furthermore, it's about distributing what works with what it's meant
> > to work with. With this seperate scheme, I can still link in the
> > wrong firmware file (the driver doesn't check the firmware version
> > until it executes) and the driver won't work. So this moves the
> > validation to run time, which users typically don't appreciate.
>
> I agree. I hate to have two klibc (one for 32 bit, and one for 64bit)
> to for initramfs to load FW for qlogic...
>
> dwmw2 's new patches to put all fw in /firmware, and built them into
> kernel could avoid that...
>
> and could make the build process to check fw version to match with
> driver in different kernel version later...
OTOH, it doesn't give you any error at build time even if you forget
to put a firmware image beforehand. The kernel continues to look for
a non-existing external firmware file. In the old code, this can't
happen.
It's just a small drawback, and I still like the idea very well,
though.
Takashi
next prev parent reply other threads:[~2008-05-30 9:52 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-28 17:20 [Ksummit-2008-discuss] Fixing the Kernel Janitors project James Bottomley
2008-05-28 17:43 ` H. Peter Anvin
2008-05-28 19:08 ` Rik van Riel
2008-05-28 20:15 ` Chris Mason
2008-05-29 10:34 ` Jiri Kosina
2008-05-31 8:38 ` Pavel Machek
2008-05-28 20:38 ` James Bottomley
2008-05-28 20:49 ` David Woodhouse
2008-05-28 21:01 ` James Bottomley
2008-05-28 21:31 ` Pekka Enberg
2008-05-28 21:42 ` James Bottomley
2008-05-28 22:18 ` David Woodhouse
2008-05-28 22:35 ` James Bottomley
2008-05-28 22:51 ` Greg KH
2008-05-28 23:23 ` Luck, Tony
2008-05-29 0:36 ` Greg KH
2008-05-29 1:00 ` Dave Jones
2008-05-29 2:26 ` Greg KH
2008-05-30 20:23 ` How many contributors are we losing Luck, Tony
2008-05-30 20:46 ` Willy Tarreau
2008-05-30 20:47 ` Greg KH
2008-05-30 23:37 ` [Ksummit-2008-discuss] " Grant Grundler
2008-05-31 19:53 ` Stefan Richter
2008-05-30 21:01 ` [Ksummit-2008-discuss] " Daniel Walker
2008-05-30 21:13 ` Hugh Dickins
2008-05-30 22:05 ` Luck, Tony
2008-05-30 22:53 ` Theodore Tso
2008-05-30 23:10 ` H. Peter Anvin
2008-05-31 1:12 ` Josh Boyer
2008-05-29 6:12 ` [Ksummit-2008-discuss] Fixing the Kernel Janitors project David Miller
2008-05-29 6:09 ` David Miller
2008-05-29 13:24 ` Peter Zijlstra
2008-05-29 14:36 ` James Bottomley
2008-05-29 15:06 ` Jiri Kosina
2008-05-29 16:32 ` Matthew Wilcox
2008-05-30 0:24 ` Stefan Richter
2008-06-02 10:32 ` Jiri Kosina
2008-06-02 10:43 ` Rafael J. Wysocki
2008-05-29 17:37 ` James Bottomley
2008-05-29 20:24 ` Rafael J. Wysocki
2008-05-31 19:21 ` Lars Noschinski
2008-06-01 16:09 ` store-same-blocksonce (was Re: [Ksummit-2008-discuss] Fixing the Kernel Janitors project) Pavel Machek
2008-06-02 8:18 ` [Ksummit-2008-discuss] Fixing the Kernel Janitors project Paul Jackson
2008-05-29 2:27 ` Matthew Wilcox
2008-05-29 5:58 ` David Miller
2008-05-29 6:17 ` Benjamin Herrenschmidt
2008-05-29 12:45 ` Theodore Tso
2008-05-29 16:15 ` RFC: Moving firmware blobs out of the kernel David Woodhouse
2008-05-29 16:47 ` [Ksummit-2008-discuss] " Greg KH
2008-05-29 20:29 ` Arjan van de Ven
2008-05-29 20:47 ` Matthew Wilcox
2008-05-29 20:55 ` Yinghai Lu
2008-05-29 20:59 ` James Bottomley
2008-05-29 21:03 ` Greg KH
2008-05-30 9:20 ` Alan Cox
2008-05-30 10:38 ` David Woodhouse
2008-05-29 21:31 ` David Miller
2008-05-29 21:57 ` Yinghai Lu
2008-05-30 9:52 ` Takashi Iwai [this message]
2008-05-30 10:37 ` David Woodhouse
2008-05-29 21:09 ` David Miller
2008-05-29 21:11 ` Arjan van de Ven
2008-05-29 23:04 ` David Woodhouse
2008-05-30 13:47 ` Arnaldo Carvalho de Melo
2008-06-01 16:17 ` Pavel Machek
2008-06-06 14:46 ` David Woodhouse
2008-06-07 9:53 ` Pavel Machek
2008-06-08 11:13 ` Mauro Carvalho Chehab
2008-05-29 22:11 ` David Woodhouse
2008-05-30 18:37 ` Grant Grundler
2008-06-07 22:14 ` Alexandre Oliva
2008-05-29 19:12 ` Jeff Garzik
2008-05-29 21:17 ` [Ksummit-2008-discuss] " Peter Zijlstra
2008-05-29 23:39 ` H. Peter Anvin
2008-05-30 9:31 ` Alan Cox
2008-05-30 9:50 ` Peter Zijlstra
2008-05-30 13:53 ` Jeff Garzik
2008-05-30 21:08 ` Alexandre Oliva
2008-05-30 23:14 ` H. Peter Anvin
2008-05-31 14:05 ` Alan Cox
2008-05-31 15:10 ` H. Peter Anvin
2008-05-30 1:27 ` Benjamin Herrenschmidt
2008-05-29 21:18 ` David Woodhouse
2008-05-30 1:22 ` Benjamin Herrenschmidt
2008-05-29 20:54 ` [Ksummit-2008-discuss] Fixing the Kernel Janitors project David Miller
2008-05-29 20:59 ` Matthew Wilcox
2008-05-29 21:12 ` Greg KH
2008-05-30 1:25 ` Benjamin Herrenschmidt
2008-05-30 2:20 ` Matthew Wilcox
2008-05-29 21:14 ` Theodore Tso
2008-05-29 21:39 ` David Miller
2008-06-01 14:11 ` Thomas Gleixner
2008-06-01 14:24 ` James Bottomley
2008-06-01 16:21 ` s2ram video problems " Pavel Machek
2008-06-01 17:55 ` Rafael J. Wysocki
2008-06-01 18:04 ` James Bottomley
2008-06-01 18:14 ` Rafael J. Wysocki
2008-06-01 18:14 ` Matthew Garrett
2008-06-01 18:17 ` Matthew Garrett
2008-06-01 20:22 ` Thomas Gleixner
2008-06-01 20:36 ` Matthew Garrett
2008-06-01 23:56 ` Benjamin Herrenschmidt
2008-05-30 1:20 ` Benjamin Herrenschmidt
2008-05-30 6:55 ` David Miller
2008-05-29 16:03 ` Jonathan Corbet
2008-05-30 0:40 ` Neil Brown
2008-05-29 14:26 ` James Bottomley
2008-05-29 11:32 ` Helge Hafting
2008-05-29 13:44 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5habi8ce51.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=arjan@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=greg@kroah.com \
--cc=ksummit-2008-discuss@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox