From: Takashi Iwai <tiwai@suse.de>
To: Chuck Ebbert <cebbert@redhat.com>
Cc: kernel list <linux-kernel@vger.kernel.org>
Subject: Re: BUG: soft lockup during suspend
Date: Mon, 26 Mar 2007 11:50:41 +0200 [thread overview]
Message-ID: <s5haby09vv2.wl%tiwai@suse.de> (raw)
In-Reply-To: <46042906.1030100@redhat.com>
At Fri, 23 Mar 2007 15:22:46 -0400,
Chuck Ebbert wrote:
>
> Takashi Iwai wrote:
> > At Tue, 20 Mar 2007 17:08:48 +0100,
> > I wrote:
> >> At Tue, 20 Mar 2007 12:05:07 -0400,
> >>>
> >>> http://lkml.org/lkml/2006/12/3/9
> >> This is a different problem.
> >> A known workaround is to provide probe_mask=1 module option.
> >
> > BTW, does this happen on the latest linus git tree? (rc4 may work,
> > though)
> >
>
> 2.6.21-rc4 works perfectly, detecting my Acer notebook's model
> properly and adding the sound devices to the bus. Very nice...
Could you try rc5? I'm afraid that one of fix patches on rc5 may
break the probing on your laptop (this path had to be applied to
recover another regression...)
If it happened, try the patch below from the latest ALSA tree.
thanks,
Takashi
[PATCH] [ALSA] hda-intel - Probe additional slots only if necessary
Probing the codec slots on ATI controller causes problems on some
devices like Acer laptops. On these devices, reading from codec
slot 3 results in the communication failure with the codec chip.
Meanwhile, some laptops (e.g. Gateway) have the codec connection
only on slot 3, and probing this slot is mandatory for them.
The patch improves the probing robustness. The additional slots
are now checked only when no codecs are found in the primary three
slots.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz>
---
commit a239a9ff89307a0a65fd9cbb02afb020bdb13de0
tree 72603176c199d3fedaeba030f3ea5691c4b5d882
parent 66753e652a094e0ab856417a5092297dbabe5fd6
author Takashi Iwai <tiwai@suse.de> Wed, 21 Mar 2007 15:14:35 +0100
committer Jaroslav Kysela <perex@suse.cz> Wed, 21 Mar 2007 15:15:24 +0100
sound/pci/hda/hda_intel.c | 16 ++++++++++++++--
1 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 517a8d7..5e478b9 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -198,6 +198,7 @@ enum { SDI0, SDI1, SDI2, SDI3, SDO0, SDO
#define RIRB_INT_MASK 0x05
/* STATESTS int mask: SD2,SD1,SD0 */
+#define AZX_MAX_CODECS 3
#define STATESTS_INT_MASK 0x07
/* SD_CTL bits */
@@ -991,7 +992,7 @@ static int __devinit azx_codec_create(st
return err;
codecs = 0;
- for (c = 0; c < azx_max_codecs[chip->driver_type]; c++) {
+ for (c = 0; c < AZX_MAX_CODECS; c++) {
if ((chip->codec_mask & (1 << c)) & probe_mask) {
err = snd_hda_codec_new(chip->bus, c, NULL);
if (err < 0)
@@ -999,7 +1000,18 @@ static int __devinit azx_codec_create(st
codecs++;
}
}
- if (! codecs) {
+ if (!codecs) {
+ /* probe additional slots if no codec is found */
+ for (; c < azx_max_codecs[chip->driver_type]; c++) {
+ if ((chip->codec_mask & (1 << c)) & probe_mask) {
+ err = snd_hda_codec_new(chip->bus, c, NULL);
+ if (err < 0)
+ continue;
+ codecs++;
+ }
+ }
+ }
+ if (!codecs) {
snd_printk(KERN_ERR SFX "no codecs initialized\n");
return -ENXIO;
}
prev parent reply other threads:[~2007-03-26 9:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-20 12:32 BUG: soft lockup during suspend Pavel Machek
2007-03-20 12:37 ` Takashi Iwai
2007-03-20 13:22 ` Pavel Machek
2007-03-20 13:39 ` Takashi Iwai
2007-03-20 16:05 ` Chuck Ebbert
2007-03-20 16:08 ` Takashi Iwai
2007-03-20 16:21 ` Takashi Iwai
2007-03-20 16:32 ` Chuck Ebbert
2007-03-20 21:00 ` Takashi Iwai
2007-03-23 19:22 ` Chuck Ebbert
2007-03-26 9:50 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5haby09vv2.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=cebbert@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox