From: Takashi Iwai <tiwai@suse.de>
To: xiakaixu1987@gmail.com
Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, Kaixu Xia <kaixuxia@tencent.com>
Subject: Re: [PATCH] ALSA: firewire: fix comparison to bool warning
Date: Tue, 10 Nov 2020 09:06:29 +0100 [thread overview]
Message-ID: <s5hblg5ljp6.wl-tiwai@suse.de> (raw)
In-Reply-To: <1604765611-8209-1-git-send-email-kaixuxia@tencent.com>
On Sat, 07 Nov 2020 17:13:31 +0100,
xiakaixu1987@gmail.com wrote:
>
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> Fix the following coccicheck warning:
>
> ./sound/firewire/amdtp-stream.h:273:6-19: WARNING: Comparison to bool
>
> Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Thanks, applied.
Takashi
> ---
> sound/firewire/amdtp-stream.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/firewire/amdtp-stream.h b/sound/firewire/amdtp-stream.h
> index 2ceb57d1d58e..a3daa1f2c1c4 100644
> --- a/sound/firewire/amdtp-stream.h
> +++ b/sound/firewire/amdtp-stream.h
> @@ -270,7 +270,7 @@ static inline bool amdtp_stream_wait_callback(struct amdtp_stream *s,
> unsigned int timeout)
> {
> return wait_event_timeout(s->callback_wait,
> - s->callbacked == true,
> + s->callbacked,
> msecs_to_jiffies(timeout)) > 0;
> }
>
> --
> 2.20.0
>
next prev parent reply other threads:[~2020-11-10 8:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 16:13 [PATCH] ALSA: firewire: fix comparison to bool warning xiakaixu1987
2020-11-10 8:06 ` Takashi Iwai [this message]
2020-11-10 8:12 ` Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hblg5ljp6.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=kaixuxia@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=xiakaixu1987@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox