From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3F30C43603 for ; Wed, 18 Dec 2019 06:33:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 95FF720717 for ; Wed, 18 Dec 2019 06:33:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726591AbfLRGdr (ORCPT ); Wed, 18 Dec 2019 01:33:47 -0500 Received: from mx2.suse.de ([195.135.220.15]:43886 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725797AbfLRGdr (ORCPT ); Wed, 18 Dec 2019 01:33:47 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 11849B1E2; Wed, 18 Dec 2019 06:33:45 +0000 (UTC) Date: Wed, 18 Dec 2019 07:33:44 +0100 Message-ID: From: Takashi Iwai To: Nathan Chancellor Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] ALSA: usx2y: Adjust indentation in snd_usX2Y_hwdep_dsp_status In-Reply-To: <20191218034257.54535-1-natechancellor@gmail.com> References: <20191218034257.54535-1-natechancellor@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Dec 2019 04:42:57 +0100, Nathan Chancellor wrote: > > Clang warns: > > ../sound/usb/usx2y/usX2Yhwdep.c:122:3: warning: misleading indentation; > statement is not part of the previous 'if' [-Wmisleading-indentation] > info->version = USX2Y_DRIVER_VERSION; > ^ > ../sound/usb/usx2y/usX2Yhwdep.c:120:2: note: previous statement is here > if (us428->chip_status & USX2Y_STAT_CHIP_INIT) > ^ > 1 warning generated. > > This warning occurs because there is a space before the tab on this > line. Remove it so that the indentation is consistent with the Linux > kernel coding style and clang no longer warns. > > This was introduced before the beginning of git history so no fixes tag. > > Link: https://github.com/ClangBuiltLinux/linux/issues/831 > Signed-off-by: Nathan Chancellor Applied, thanks. Takashi