From: Takashi Iwai <tiwai@suse.de>
To: Keith Packard <keithp@keithp.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
Kailang Yang <kailang@realtek.com>,
Hui Wang <hui.wang@canonical.com>,
David Henningsson <david.henningsson@canonical.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Enable HP amp and mute LED on HP Folio 9480m
Date: Thu, 16 Jul 2015 12:26:40 +0200 [thread overview]
Message-ID: <s5hbnfcl7of.wl-tiwai@suse.de> (raw)
In-Reply-To: <86k2u1qlls.fsf@hiro.keithp.com>
On Wed, 15 Jul 2015 21:14:39 +0200,
Keith Packard wrote:
>
> Takashi Iwai <tiwai@suse.de> writes:
>
> > Thanks! The new patch looks good, but I think we don't have to use
> > the headset code, as your case looks more like a headphone, not a
> > combo headset that needs the special handling. If so, the change can
> > be reduced something like below. Could you check whether this is
> > enough?
>
> Yes, that seems a lot simpler and works fine. I did remove the
> led_power_filter setting; that doesn't seem relevant for GPIO-based
> leds, and isn't necessary on my device in any case.
>
> This patch is now otherwise essentially the same as yours, with the
> addition of comments.
>
> Thanks again for your help; it's always interesting to dive into some
> different area of the kernel and see how it works.
Great, I queued the patch now. It'll be included in the next pull
request for 4.2-rc3.
thanks,
Takashi
next prev parent reply other threads:[~2015-07-16 10:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 16:40 [PATCH] ALSA: hda/realtek: Enable headphone amp on HP Folio 9480m Keith Packard
2015-07-14 17:44 ` [PATCH] ALSA: hda/realtek: Enable HP amp and mute LED " Keith Packard
2015-07-14 19:29 ` Takashi Iwai
2015-07-15 2:37 ` Keith Packard
2015-07-15 8:14 ` Takashi Iwai
2015-07-15 19:14 ` Keith Packard
2015-07-16 10:26 ` Takashi Iwai [this message]
2015-07-16 14:48 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hbnfcl7of.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=david.henningsson@canonical.com \
--cc=hui.wang@canonical.com \
--cc=kailang@realtek.com \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox