From: Takashi Iwai <tiwai@suse.de>
To: Paulo Marques <pmarques@grupopie.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup
Date: Wed, 02 Feb 2005 12:29:35 +0100 [thread overview]
Message-ID: <s5hbrb3yzc0.wl@alsa2.suse.de> (raw)
In-Reply-To: <41FFB94C.3050807@grupopie.com>
At Tue, 01 Feb 2005 17:15:56 +0000,
Paulo Marques wrote:
>
> [1 <text/plain; us-ascii (7bit)>]
> Takashi Iwai wrote:
> > [...]
> >
> > Thanks, that looks almost fine except:
> >
> >
> >>diff -uprN -X dontdiff vanilla-2.6.11-rc2-bk9/sound/core/sound.c linux-2.6.11-rc2-bk9/sound/core/sound.c
> >>--- vanilla-2.6.11-rc2-bk9/sound/core/sound.c 2005-01-31 20:05:34.000000000 +0000
> >>+++ linux-2.6.11-rc2-bk9/sound/core/sound.c 2005-02-01 15:02:04.000000000 +0000
> >>@@ -401,7 +401,6 @@ EXPORT_SYMBOL(snd_hidden_kfree);
> >> EXPORT_SYMBOL(snd_hidden_vmalloc);
> >> EXPORT_SYMBOL(snd_hidden_vfree);
> >> #endif
> >>-EXPORT_SYMBOL(snd_kmalloc_strdup);
> >> EXPORT_SYMBOL(copy_to_user_fromio);
> >> EXPORT_SYMBOL(copy_from_user_toio);
> >> /* init.c */
> >
> >
> > I guess here missing EXPORT(snd_hidden_kstrdup)?
>
> Good catch.
>
> Here is the revised patch... I hope this time everything is ok
That's perfect :)
thanks,
Takashi
prev parent reply other threads:[~2005-02-02 11:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-01 3:28 [PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup pmarques
2005-02-01 11:17 ` Takashi Iwai
2005-02-01 12:27 ` Paulo Marques
2005-02-01 12:32 ` Takashi Iwai
2005-02-01 13:07 ` Paulo Marques
2005-02-01 13:16 ` Takashi Iwai
2005-02-01 15:39 ` Paulo Marques
2005-02-01 16:39 ` Takashi Iwai
2005-02-01 17:15 ` Paulo Marques
2005-02-02 11:29 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hbrb3yzc0.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=akpm@osdl.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmarques@grupopie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox